Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

touch grass #4039

Merged
merged 1 commit into from
Dec 9, 2023
Merged

touch grass #4039

merged 1 commit into from
Dec 9, 2023

Conversation

J3fftw1
Copy link
Contributor

@J3fftw1 J3fftw1 commented Dec 5, 2023

Description

Allow Slimefun to work on 1.20.3

Proposed changes

make grass version dependent since they changed the material tag
https://www.spigotmc.org/threads/spigot-bungeecord-1-20-3.628172/

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

Copy link
Contributor

github-actions bot commented Dec 5, 2023

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: acd63f9d

https://preview-builds.walshy.dev/download/Slimefun/4039/acd63f9d

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev added the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label Dec 5, 2023
@JustAHuman-xD JustAHuman-xD added the 🎮 Game Update This pull request adds compatibility with a new version of Minecraft. label Dec 7, 2023
@WalshyDev WalshyDev merged commit d651661 into Slimefun:master Dec 9, 2023
15 checks passed
@J3fftw1 J3fftw1 deleted the 1.20.3 branch December 9, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎮 Game Update This pull request adds compatibility with a new version of Minecraft. 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants