Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow items to be unlocked in recipe menu #3628

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Allow items to be unlocked in recipe menu #3628

wants to merge 12 commits into from

Conversation

TheBusyBiscuit
Copy link
Member

Description

Continuiation of #3296, drawn into this repo to clean up some stuff and refactor things.
All credit goes to @RobotHanzo

@github-actions github-actions bot added the 🎈 Feature This Pull Request adds a new feature. label Jul 25, 2022
@github-actions
Copy link
Contributor

Your Pull Request was automatically labelled as: "🎈 Feature"
Thank you for contributing to this project! ❤️

svr333
svr333 previously approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@svr333 svr333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code still looks good to me

@TheBusyBiscuit TheBusyBiscuit changed the title Feature/unlock items in recipe menu Allow items to be unlocked in recipe menu Jul 28, 2022
@TheBusyBiscuit TheBusyBiscuit marked this pull request as ready for review August 8, 2022 17:56
@TheBusyBiscuit TheBusyBiscuit requested a review from a team as a code owner August 8, 2022 17:56
@TheBusyBiscuit
Copy link
Member Author

Alright, finished the cleanup of this.
It now uses the proper method that includes all the research checks, so it should no longer cause a big flood of exceptions when using it with insufficient levels.

This is now ready for review! @svr333
I also tested it, so it's mergeable imo

@TheBusyBiscuit TheBusyBiscuit requested a review from svr333 August 8, 2022 18:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

svr333
svr333 previously approved these changes Aug 8, 2022
View reviewed changes
JustAHuman-xD
JustAHuman-xD previously approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just wondering about a package private class

src/main/java/io/github/thebusybiscuit/slimefun4/implementation/guide/UnlockableItemStack.java Outdated Show resolved Hide resolved
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Jun 29, 2023
@WalshyDev WalshyDev dismissed stale reviews from JustAHuman-xD and svr333 via 8152b6b July 3, 2023 11:43
@WalshyDev WalshyDev removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Jul 3, 2023
@WalshyDev @J3fftw1
Update src/main/java/io/github/thebusybiscuit/slimefun4/implementatio…
6e8094f 
…n/guide/SurvivalSlimefunGuide.java

Co-authored-by: J3fftw <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023 •
edited
Loading

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: d7ddf859

https://preview-builds.walshy.dev/download/Slimefun/3628/d7ddf859

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@J3fftw1 @JustAHuman-xD
Update src/main/java/io/github/thebusybiscuit/slimefun4/implementatio…
e572df0 
…n/guide/UnlockableItemStack.java

Co-authored-by: JustAHuman-xD <[email protected]>
J3fftw1
J3fftw1 previously approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@J3fftw1 J3fftw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Dec 5, 2023
@WalshyDev WalshyDev removed the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Dec 5, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Sfiguz7 Sfiguz7 added the 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. label Dec 6, 2023
@J3fftw1 J3fftw1 added Build tested Used to indicate the PR preview build has been tested by one of the team and removed 🎯 Needs testing This Issue needs to be tested by our team to see if it can be reproduced. labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustAHuman-xD JustAHuman-xD JustAHuman-xD left review comments

@Sfiguz7 Sfiguz7 Sfiguz7 left review comments

@Sefiraat Sefiraat Sefiraat left review comments

@J3fftw1 J3fftw1 J3fftw1 approved these changes

@svr333 svr333 svr333 left review comments

@WalshyDev WalshyDev Awaiting requested review from WalshyDev

At least 2 approving reviews are required to merge this pull request.

Assignees

@WalshyDev WalshyDev

@svr333 svr333

Labels
Build tested Used to indicate the PR preview build has been tested by one of the team 🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@TheBusyBiscuit @WalshyDev @Sefiraat @svr333 @Sfiguz7 @J3fftw1 @JustAHuman-xD @TheBusyBot @RobotHanzo