Change protocol hardware address to a table and handle different address types #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2022
|
The "HardwareAddress" is different from the Ip address, the ip address can go under the HardwareInfo table. I know that the current implementation of the mac address kinda sucks, I'm waiting for fixed size array support to be added to typescript soon here: google/flatbuffers#7581 |
TheButlah
reviewed
Oct 17, 2022
TheButlah
reviewed
Oct 17, 2022
TheButlah
reviewed
Oct 17, 2022
Co-authored-by: Ryan Butler <[email protected]>
TheButlah
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type definition got changed because it was not usable and would have required too much work to parse. especially on the js part.
Making it a table makes it for other stuff to be supported also