Stop using Twemoji and just use SVGs for it #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
approved these changes
Apr 7, 2025
Eirenliel
reviewed
Apr 23, 2025
|
No it doesn't work with other places as it's all manually replaced, the reason why I don't like the current way of doing it is that it's kind of a hack that works in different ways depending on the browser and doesn't even work in Linux. We could use a library that replaces all emojis with an svg automatically but it might be heavier in size than the two color fonts combined, but I'm not sure |
Eirenliel
approved these changes
Apr 23, 2025
|
Emojis will still work, it will just use the os default emoji font |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the ~2MB of emoji fonts that we had with normal SVG imports which reduced the total size of the binary and we don't have to make any special hack for fonts in some OSes.