Skip to content

Conversation

@topin89
Copy link

@topin89 topin89 commented Aug 29, 2019

Changes are tiny:

  • app\frame_grabber added to includes path
  • RPLIDAR_SDK_VERSION macro now separated from quotes with spaces, so compiler don't confuse it with string literals
  • #include <string> added to stdafx.h in frame_grabber

@bitmeal
Copy link

bitmeal commented Dec 13, 2019

I would like to bump this PR and stress the importance!
The above mentioned modifications are vital to get the sdk and examples building in current versions of VS.

Per my experience and, the necessary adaptations can be reduced to:

  • app\frame_grabber added to include path of lidarmgr.cpp
  • RPLIDAR_SDK_VERSION macro now separated from quotes with spaces, so compiler don't confuse it with string literals
  • #include added to stdafx.h in frame_grabber does not seem necessary

@WubinXia WubinXia force-pushed the master branch 4 times, most recently from e13f3b8 to 504a2e5 Compare April 9, 2020 12:18
@LFBFerreira
Copy link

LFBFerreira commented Nov 9, 2020

Thanks for this! I'm trying to create a VS C++ project with this SDK and openFrameworks. And its working in VS 2019 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants