Adjustable Video Birate with FFMPEG and Fixed Seed Not Randomizing #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotfix for multi-gpu error: SkyworkAI#66
Changed wrong file
…not divisible by world_size=2 See SkyworkAI#66
Rewrote the hotfix to scale more generally past 2 GPUs. Tested on 4 GPUs, 2 GPUs, and 1 GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I synced the rest of the code for the multi-gpu fix and just have minimal changes in video_generate.py for the ffmpeg video improvement and fixing the seed if you want to use them. The FFPEG will be used only when available, otherwise defaulting to the OpenCV video export you had before (but actually still higher bitrate at ~7mbps instead of 2.5mbps because of setting the cap higher there as well).
See:
#72
#79