Corpse profit tracker #1152
Open
Corpse profit tracker #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some considerations for the future:
Also, the amounts in the initial picture are bugged. The issue causing that was fixed and is in the initial PR but the data was saved when it happened so I cba to reset and mine more. |
olim88
reviewed
Feb 6, 2025
...va/de/hysky/skyblocker/skyblock/dwarven/profittrackers/corpse/CorpseProfitHistoryScreen.java
Outdated
Show resolved
Hide resolved
...va/de/hysky/skyblocker/skyblock/dwarven/profittrackers/corpse/CorpseProfitHistoryScreen.java
Outdated
Show resolved
Hide resolved
...va/de/hysky/skyblocker/skyblock/dwarven/profittrackers/corpse/CorpseProfitHistoryScreen.java
Outdated
Show resolved
Hide resolved
...ain/java/de/hysky/skyblocker/skyblock/dwarven/profittrackers/corpse/CorpseProfitTracker.java
Outdated
Show resolved
Hide resolved
Emirlol
force-pushed
the
corpse-profit-tracker-xd
branch
from
9860304 to
1e4baab
Compare
|
The changes at 1e4baab need testing. I can't do this since, well, I am banned from Hypixel. |
olim88
approved these changes
Feb 14, 2025
LifeIsAParadox
added
merge me please
- Extract `CorpseLoot` and `Reward` inner classes into separate classes - Use translatables where it makes sense - Add config option to toggle corpse profit tracker (can't believe I forgot this on corpse tracker as well) - Some minor command adjustments and fixes to both `PowderMiningTracker` and `CorpseProfitTracker` - Refactored `CorpseProfitHistoryScreen` into `CorpseProfitScreen`. The button that switched from one to the other is now a view switch button that changes the displayed list, and functionality of both screens is combined in one. - Add hover/click events to the profit text sent when a corpse is looted that opens the screen
This way, they don't display the price per unit when the amount is 1.
Emirlol
force-pushed
the
corpse-profit-tracker-xd
branch
from
15b1d47 to
4477573
Compare
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Feb 24, 2025
LifeIsAParadox
added
merge me please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a corpse profit tracker for the glacite mineshafts. The screen is accessed with a command:
/skyblocker rewardTrackers corpse list.Technical changes
Extracts
CorpseTypefrom the corpse finder into a separate file, with an extra field and some methods to make it easier for the tracker.I also changed the color of the types according to the color of the text that appears when you loot a corpse.
Refactored some code from the
PowderMiningTrackerintoAbstractProfitTrackerandPowderMiningTracker, along with the newCorpseProfitTrackerinherit from the said abstract class. There's not much inheritance magic other than some utility methods.Moved the
PowderMiningTrackerinto a separate packageAlso refactored the commands in
PowderMiningTrackerto not clutter the first level of subcommands on the namespace, so it goes like/skyblocker rewardTrackers powderMining <actual subcommand>nowAdded a toggle config for
PowderMiningTracker. I can't believe I forgot this on the initial PR...Added 2 new screens and 2 lists for displaying the relevant data for those screens:
CorpseProfitScreen&RewardListfor summaryCorpseProfitHistoryScreen&CorpseListfor historyThe summary screen shows the total of all rewards while the history screen shows each individual corpse's rewards, along with timestamps.
Summary Screen
History Screen