Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brick / Nether Brick Aliases #123

Open
wants to merge 1 commit into
base: minimized-aliases
Choose a base branch
from

Conversation

erenkarakal
Copy link
Member

@erenkarakal erenkarakal commented Feb 4, 2025

Adds brick and nether brick aliases. The existing PR (#122) doesn't include nether bricks and doesn't match the Minecraft IDs

Previous behaviour:

brick = doesn't exist
bricks = "bricks banner pattern" - giving it to a player gives a brick block
nether brick = doesn't exist
nether bricks = "nether bricks or nether brick" - giving it to a player gives either item randomly
nether brickss = "nether brick" - item

New behaviour:

brick = "brick" - item
bricks = "bricks banner pattern" - giving it to a player gives a brick block
nether brick = "nether brick" - item
nether bricks = "nether bricks" - block
nether brickss = doesn't exist

This a quick patch, there is a bigger issue that needs to be fixed that will be discussed in a different issue.
With this PR, comparing type of {_block} to bricks doesn't work and is a known issue. The current workaround is comparing it to 1 bricks.

Related: SkriptLang/Skript#7484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant