Skip to content

Add Brick / Nether Brick Aliases #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

erenkarakal
Copy link
Member

@erenkarakal erenkarakal commented Feb 4, 2025

Adds brick and nether brick aliases. The existing PR (#122) doesn't include nether bricks and doesn't match the Minecraft IDs

Previous behaviour:

brick = doesn't exist
bricks = "bricks banner pattern" - giving it to a player gives a brick block
nether brick = doesn't exist
nether bricks = "nether bricks or nether brick" - giving it to a player gives either item randomly
nether brickss = "nether brick" - item

New behaviour:

brick = "brick" - item
bricks = "bricks banner pattern" - giving it to a player gives a brick block
nether brick = "nether brick" - item
nether bricks = "nether bricks" - block
nether brickss = doesn't exist

This a quick patch, there is a bigger issue that needs to be fixed that will be discussed in a different issue.
With this PR, comparing type of {_block} to bricks doesn't work and is a known issue. The current workaround is comparing it to 1 bricks.

Related: SkriptLang/Skript#7484

@Efnilite Efnilite added the bug Something isn't working label Feb 25, 2025
@Efnilite Efnilite merged commit 2ebfe19 into SkriptLang:minimized-aliases Feb 25, 2025
@tamikulan
Copy link

I'm having the same problem with resin brick and resin bricks.
This issue is not fixed in Skript 2.10.2 either.

@sovdeeth
Copy link
Member

sovdeeth commented Mar 2, 2025

Yes, this wouldn't cover resin bricks. You can open a new issue for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants