Prep for building node addon against precompiled skipruntime #909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not useful on its own, but I wanted to put this PR up in case anyone sees issues or problems with this approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the build in preparation for building the native node addon against a precompiled skipruntime library. The aim is to enable end users to first install the binary skip runtime to their host and then install the addon just as a standard npm dependency, without needing to build the skiplang toolchain or have it installed. To this end, this PR:
adapts the npm build (package.json and binding.gyp files) to expect the skipruntime library to be installed on the host;
adapts the dev build (Makefiles) to build the skipruntime library from the current sources, and set the other builds and tests to use this current version.
At a high level, what this means is that the
npmcommands use the host-installed skipruntime, and are therefore meant for use by end users; while themakecommands use the skipruntime built from current sources, and are therefore meant for development and testing use.