-
Notifications
You must be signed in to change notification settings - Fork 24
[WIP] OSX support #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[WIP] OSX support #377
Conversation
e986cd4
to
43baeed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of this isn't specific to macOS right? It would be better to divide into 2 PRs I think.
modified_files = mutable Vector[]; | ||
deleted_files = mutable Vector[]; | ||
|
||
// FIXME: This is O(n^2). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the srcs arrays already sorted? A linear traversal of new_srcs seems unavoidable. So perhaps the best that can be done is to sort old_srcs and use a binary search instead of Array.find. Maybe it would be better to also sort new_srcs and then be able to narrow the binary search of old_srcs at each step.
That's correct. The aim of this branch is to get OSX support down the line, and I made it a PR for visibility. I'll split self-contained commits out into separate PRs. |
Its `Error` superclass constructor requires an argument of type `string | undefined`, so change from `: any` to `?: string`.
In the runtime it is an `unsigned char`, so declare it as a `number` in TS.
To help code review, I have extracted a few small changes that might be functional from upcoming changes to appease the type-checker and linter. Some individual commit summaries have more info.
Add multiple resources test
Now that array proxying is gone with SkipLabs#526
(stacked on SkipLabs#519) Adds a runnable version of the getting started example and applies a handful of unrelated bug fixes and cleanups. Run as follows: ``` cd skipruntime-ts make bunbuild bun run examples/groups.ts & bun run examples/groups-server.ts & bun run examples/groups-client ```
…ipLabs#527) See second commit for payoff in client code
This endpoint previously responded with a JSON-encoded string (i.e. including quotes).
This endpoint previously responded with a JSON-encoded string (i.e. including quotes).
This is a documentation only thing.
This is a documentation only thing.
No description provided.