Skip to content

Fix for issue #2117 #2230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Fix for issue #2117 #2230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
353f2e2
Fix for issue #2117
brianpopow Sep 15, 2022
61e7457
Merge remote-tracking branch 'origin/main' into bp/FixIssue2117
brianpopow Sep 15, 2022
0c62aeb
Enable .NET 7 workflows
JimBobSquarePants Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 12 additions & 14 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,18 @@ jobs:
sdk-preview: true
runtime: -x64
codecov: false
# Temp disabled due to runtime preview issues.
# https://github.com/SixLabors/ImageSharp/issues/2117
#- os: macos-latest
# framework: net7.0
# sdk: 7.0.x
# sdk-preview: true
# runtime: -x64
# codecov: false
#- os: windows-latest
# framework: net7.0
# sdk: 7.0.x
# sdk-preview: true
# runtime: -x64
# codecov: false
- os: macos-latest
framework: net7.0
sdk: 7.0.x
sdk-preview: true
runtime: -x64
codecov: false
- os: windows-latest
framework: net7.0
sdk: 7.0.x
sdk-preview: true
runtime: -x64
codecov: false
- os: ubuntu-latest
framework: net6.0
sdk: 6.0.x
Expand Down
4 changes: 2 additions & 2 deletions src/ImageSharp/PixelFormats/PixelImplementations/Bgra32.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public uint PackedValue

/// <inheritdoc/>
[MethodImpl(InliningOptions.ShortMethod)]
public void FromVector4(Vector4 vector) => this.Pack(ref vector);
public void FromVector4(Vector4 vector) => this.Pack(vector);

/// <inheritdoc/>
[MethodImpl(InliningOptions.ShortMethod)]
Expand Down Expand Up @@ -302,7 +302,7 @@ public void FromRgba64(Rgba64 source)
/// </summary>
/// <param name="vector">The vector containing the values to pack.</param>
[MethodImpl(InliningOptions.ShortMethod)]
private void Pack(ref Vector4 vector)
private void Pack(Vector4 vector)
{
vector *= MaxBytes;
vector += Half;
Expand Down