Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended tool switch when typing #38

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

SunnyHuangCodebase
Copy link
Contributor

@SunnyHuangCodebase SunnyHuangCodebase commented Mar 9, 2024

Resolves issue #1

Bug: Pressing the "b" key erroneously activates the build tool when user is attempting to type into a textbox.

Fix: Ignore "b" key presses when typing into <textarea> and <input> elements.

@Sinetheta
Copy link
Owner

Thanks for the submission @SunnyHuangCodebase sorry I didn't notice it earlier. The "Delete" path also suffers the same problem but I'll merge this now and look into the logic where the handler is applied.

@Sinetheta
Copy link
Owner

I think CI didn't run because of a setting on this repository. The docs make it sound like I should be able to "Approve and run" but that option doesn't appear. Maybe because I took so long to respond that it's gone?

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

@Sinetheta Sinetheta merged commit 1a8990b into Sinetheta:master Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants