-
Notifications
You must be signed in to change notification settings - Fork 5
Add Inverse dynamics class using TSID #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
EtienneAr
wants to merge
75
commits into
main
Choose a base branch
from
tsid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o get foot nb + member variables named more explicitely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is still in progress, here is my todo list before asking for any review (also, by the time I finish, I might split it in several smaller PRs to make it more legible) :
Member function of the ID class (like
setTarget
,solve
) should be templated on the vector type, and useconst Eigen::Ref<VectorType> &
sampleBase
,samplePosture
andposeBase
do not require to be kept as member variablefoot_forces
should be better typed than a flattened list, probablyMatrixtype<3, -1>
RobotModelHandler
should avec methods to extract confguration and velocity from the stategetConfiguration
getVelocity
.head(nq)
.tail(nv)
and replace when appropriateAre all tsid tasks tested individually ?
Does solver need a resize after adding/removing contacts ?
bindings
UpdateInternalData
KinodynamicsID
,KinodynamidsID::Settings
getFootPose
Should the data handler keep a copy of the state ?
getFootPose
should take the foot index as argument, not the name (more effcient solution by default)BaseTask : use data handler
Make suer TSID PR is merged, and set minimum version in CMake accordingly
Add asserts everywhere to check dimensions
ID should also give the q and v after interpollation, to feed forward to the robot
getAccelerations shouldn't be returning a const cast
Take into account 6D contact forces
Do a subclass for centroidal
Make ID work for talos kinodynamics
Add Angular Momentum task--> Not needed for now (maybe for centroidal)Which sample value & derivative to set ?Add unit testDouble check that Com task value, derivative is good--> Not needed for now (maybe for centroidal)How to test derivative (in unittests ?) -> Speed of convergence ??Compute task second derivative ?? --> is it worth ? Test it !Contact pose should be indexed by foot number not foot name
Necessary ?