Skip to content

chore(deps): lock file maintenance #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
+5 −4
Merged

chore(deps): lock file maintenance #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -5440,11 +5440,12 @@ __metadata:
linkType: hard

"is-number-object@npm:^1.0.4":
version: 1.0.7
resolution: "is-number-object@npm:1.0.7"
version: 1.1.0
resolution: "is-number-object@npm:1.1.0"
dependencies:
has-tostringtag: ^1.0.0
checksum: d1e8d01bb0a7134c74649c4e62da0c6118a0bfc6771ea3c560914d52a627873e6920dd0fd0ebc0e12ad2ff4687eac4c308f7e80320b973b2c8a2c8f97a7524f7
call-bind: ^1.0.7
has-tostringtag: ^1.0.2
checksum: 965f91493e5c02a44bb9c5d8dd4ae40da20bd9bd1cff9cd92e2f2e66a486935a0a01f8a4744eab033c450888f01a4ec3226e1c75bbcff973ce12d06ed79eb17b
languageName: node
linkType: hard

Unchanged files with check annotations Beta

View file
src/utils.js
const publicPath =
typeof compilation.options.output.publicPath !== 'undefined'
? compilation.options.output.publicPath
: path.relative(path.dirname(filename), '.'); // TODO: How to test this? I haven't written this logic, unsure what it does

Check warning on line 18 in src/utils.js

GitHub Actions / Run ESLint using Node.js LTS 

Unexpected 'todo' comment: 'TODO: How to test this? I haven't...'
return ensureTrailingSlash(publicPath);
}
View file
test.js
expect(pluginData.assets).toMatchSnapshot();
});
// TODO: No idea what this does, actually... Coverage currently hits it, but the logic is untested.

Check warning on line 81 in test.js

GitHub Actions / Run ESLint using Node.js LTS 

Unexpected 'todo' comment: 'TODO: No idea what this does,...'
test.todo('should handle missing `publicPath`');
test('should add file missing "/" to public path', async () => {