Skip to content

chore(deps): update dependency husky to v9 - autoclosed #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+7 −7
Closed

chore(deps): update dependency husky to v9 - autoclosed #416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -43,7 +43,7 @@
"eslint-config-simenb-base": "^15.0.1",
"express": "^4.17.1",
"html-webpack-plugin": "^5.2.0",
"husky": "^8.0.0",
"husky": "^9.0.0",
"jest": "^29.5.0",
"jest-watch-typeahead": "^2.2.2",
"licensor": "^4.0.0",
12 changes: 6 additions & 6 deletions yarn.lock
View file
Original file line number Diff line number Diff line change
@@ -1884,7 +1884,7 @@ __metadata:
express: ^4.17.1
globby: ^11.1.0
html-webpack-plugin: ^5.2.0
husky: ^8.0.0
husky: ^9.0.0
jest: ^29.5.0
jest-watch-typeahead: ^2.2.2
licensor: ^4.0.0
@@ -4948,12 +4948,12 @@ __metadata:
languageName: node
linkType: hard

"husky@npm:^8.0.0":
version: 8.0.3
resolution: "husky@npm:8.0.3"
"husky@npm:^9.0.0":
version: 9.0.11
resolution: "husky@npm:9.0.11"
bin:
husky: lib/bin.js
checksum: 837bc7e4413e58c1f2946d38fb050f5d7324c6f16b0fd66411ffce5703b294bd21429e8ba58711cd331951ee86ed529c5be4f76805959ff668a337dbfa82a1b0
husky: bin.mjs
checksum: 1aebc3334dc7ac6288ff5e1fb72cfb447cfa474e72cf7ba692e8c5698c573ab725c28c6a5088c9f8e6aca5f47d40fa7261beffbc07a4d307ca21656dc4571f07
languageName: node
linkType: hard

Unchanged files with check annotations Beta

View file
src/utils.js
const publicPath =
typeof compilation.options.output.publicPath !== 'undefined'
? compilation.options.output.publicPath
: path.relative(path.dirname(filename), '.'); // TODO: How to test this? I haven't written this logic, unsure what it does

Check warning on line 18 in src/utils.js

GitHub Actions / Run ESLint using Node.js LTS 

Unexpected 'todo' comment: 'TODO: How to test this? I haven't...'
return ensureTrailingSlash(publicPath);
}
View file
test.js
expect(pluginData.assets).toMatchSnapshot();
});
// TODO: No idea what this does, actually... Coverage currently hits it, but the logic is untested.

Check warning on line 81 in test.js

GitHub Actions / Run ESLint using Node.js LTS 

Unexpected 'todo' comment: 'TODO: No idea what this does,...'
test.todo('should handle missing `publicPath`');
test('should add file missing "/" to public path', async () => {