Skip to content

Fixes for 2d struct simulation #562

Open
ktbolt wants to merge 5 commits into
SimVascular:mainfrom
ktbolt:2D-struct-simulation-fails_557
Open

Fixes for 2d struct simulation #562
ktbolt wants to merge 5 commits into
SimVascular:mainfrom
ktbolt:2D-struct-simulation-fails_557

Conversation

@ktbolt
Copy link
Copy Markdown
Collaborator

@ktbolt ktbolt commented Jun 3, 2026

I've fixed some indexing and an Eigen error in material models (#557).

@ktbolt ktbolt requested review from divya-adil and hanzhao2020 June 3, 2026 00:36
@ktbolt
Copy link
Copy Markdown
Collaborator Author

ktbolt commented Jun 3, 2026

I will add a test for this.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.07%. Comparing base (f521770) to head (4bae8b0).

Files with missing lines Patch % Lines
Code/Source/solver/read_files.cpp 50.00% 4 Missing ⚠️
Code/Source/solver/mat_fun.h 57.14% 3 Missing ⚠️
Code/Source/solver/mat_models.cpp 50.00% 2 Missing ⚠️
Code/Source/solver/sv_struct.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
+ Coverage   69.04%   69.07%   +0.02%     
==========================================
  Files         181      181              
  Lines       34121    34132      +11     
  Branches     5897     5901       +4     
==========================================
+ Hits        23560    23577      +17     
+ Misses      10424    10417       -7     
- Partials      137      138       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread Code/Source/solver/read_files.cpp Outdated
Comment thread Code/Source/solver/mat_fun.h Outdated
Copy link
Copy Markdown
Contributor

@hanzhao2020 hanzhao2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktbolt Looks good to me, thanks for making these changes!

@ktbolt
Copy link
Copy Markdown
Collaborator Author

ktbolt commented Jun 4, 2026

@divya-adil Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants