[SL-ONLY] Feature/rangehood app #698

bhmanda-silabs · 2025-10-29T05:40:35Z

Summary

This PR introduces new Matter Rangehood example implementing composite device type of Fan and Light.

Summary of Updates:

Implemented multi-endpoint architecture:

Root Node Endpoint (ID: 0)
Fan Endpoint (ID: 1)
Light Endpoint(ID: 2)

Added Fan control and Light On/Off control. Added button implementation to control fan on/off.
Also added LED mapping to display current state of the light.

Related issues

MATTER-5148

Testing

Verified commissioning and basic functionality on SiWx917 evaluation board.
Validated fan control via cluster commands as well as on BTN1 Press.
Validated lighting on/off via cluster commands

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

PR title is
descriptive
Apply the
“When in Rome…”
rule (coding style)
PR size is short
Try to avoid "squashing" and "force-update" in commit history
CI time didn't increase

See: Pull Request Guidelines

Note

Introduces a Silabs RangeHood example with extractor hood fan and light endpoints, button-driven fan toggle, LED light feedback, and full ZAP data model + GN build integration.

Examples • Silabs RangeHood App
- Adds composite device with endpoints: 0 (Root), 1 (Extractor Hood/FanControl), 2 (Light/OnOff).
- New runtime: RangeHoodManager, ExtractorHoodEndpoint, LightEndpoint, AppTask, DataModelCallbacks.
FanControl (endpoint 1)
- Maps FanMode (Off/Low/Medium/High/On/Auto/Smart) to PercentCurrent; syncs on init.
- Handles PercentSetting/FanMode attribute changes; button (BTN1) toggles FanMode Off⇄High.
Light (endpoint 2)
- On/Off attribute handling with LED feedback and accessors for current state.
Build & Data Model
- Adds GN targets (BUILD.gn, .gn, Wi‑Fi args) and vendor config (CHIPProjectConfig.h).
- Introduces ZAP/Matter model (rangehood-wifi-app.zap/.matter) defining clusters and endpoints; enables OTA Requestor.
UI/Platform
- LCD/QR support hooks (where available); button routing via Silabs platform; event-driven handlers.

^{Written by Cursor Bugbot for commit 59ca047. This will update automatically on new commits. Configure here.}

examples/rangehood-app/silabs/.gn copy

examples/rangehood-app/silabs/include/AppTask.h

examples/rangehood-app/silabs/include/RangeHoodManager.h

examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h

examples/rangehood-app/rangehood-app-common/src/LightEndpoint.cpp

examples/rangehood-app/silabs/.gn copy

examples/rangehood-app/silabs/build_for_wifi_args.gni

examples/rangehood-app/silabs/include/AppConfig.h

examples/rangehood-app/silabs/src/RangeHoodUI.cpp

examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

arun-silabs · 2025-11-10T11:39:41Z

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

+{
+    chip::app::DataModel::Nullable<chip::Percent> percentSetting;
+
+    chip::DeviceLayer::PlatformMgr().LockChipStack();


This will not cause any hang issues?
Should ScheduleWork be used instead?

they are already call from chip stack only right?

Yes, but if they are called from AppTask, it may lead to hangs due to deadlock. Function comments can be added to explain the usage of this API and potential risks

arun-silabs · 2025-11-10T11:40:27Z

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

+Status ExtractorHoodEndpoint::GetFanMode(chip::app::Clusters::FanControl::FanModeEnum & fanMode) const
+{
+    chip::DeviceLayer::PlatformMgr().LockChipStack();
+    Status status = chip::app::Clusters::FanControl::Attributes::FanMode::Get(mEndpointId, &fanMode);


same comment as above. Should ScheduleWork be used?

they are already call from chip stack only right?

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

examples/rangehood-app/silabs/include/AppEvent.h

examples/rangehood-app/silabs/include/RangeHoodManager.h

examples/rangehood-app/silabs/src/AppTask.cpp

examples/rangehood-app/rangehood-app-common/include/LightEndpoint.h

examples/rangehood-app/silabs/BUILD.gn

examples/rangehood-app/silabs/data_model/BUILD.gn

Copilot

Pull Request Overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 3 comments.

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

examples/rangehood-app/silabs/include/CHIPProjectConfig.h

examples/rangehood-app/silabs/BUILD.gn

examples/rangehood-app/silabs/data_model/BUILD.gn

cursor · 2025-11-11T06:42:21Z

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

+    case FanControl::FanModeEnum::kAuto: {
+        // For Auto/Smart modes, update the FanMode attribute to reflect the current mode
+        return UpdateFanModeAttribute(aNewFanMode);
+    }


Bug: Improve Fan Mode Attribute Update Efficiency

For Auto and Smart fan modes, UpdateFanModeAttribute is called to set the FanMode attribute to the value it was just changed to (since this code runs in the attribute change callback). This redundantly writes the same value back to the attribute, which is wasteful and illogical. The air-purifier-app implementation simply breaks without re-setting the attribute for these modes.

examples/rangehood-app/rangehood-app-common/src/LightEndpoint.cpp

jmartinez-silabs · 2025-11-11T10:58:44Z

Restyle is failing. Please provide description on it was tested. Ideally, all description is added in the proposed template section and not added by the bot post PR creation.

jmartinez-silabs · 2025-11-11T11:07:32Z

examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h

+     * @param mediumPercent Percent value for Medium mode (typically 60)
+     * @param highPercent Percent value for High/On mode (typically 100)
+     */
+    CHIP_ERROR Init(chip::Percent offPercent, chip::Percent lowPercent, chip::Percent mediumPercent, chip::Percent highPercent);


Why do we have a OffPercent here? It is always 0 based on what I read on the spec

The value 0 (zero) in this attribute SHALL be in a range by itself. This range SHALL map to Off.

As per your comment, offPercent is not needed, so removed offpercent here in Init.

jmartinez-silabs · 2025-11-11T11:12:30Z

examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h

+     * @brief Initialize the ExtractorHood endpoint.
+     * @param offPercent Percent value for Off mode (typically 0)
+     * @param lowPercent Percent value for Low mode (typically 30)
+     * @param mediumPercent Percent value for Medium mode (typically 60)
+     * @param highPercent Percent value for High/On mode (typically 100)


Where does the "Typically" value come from? I don't see any reference from the spec suggesting those values.

Each FanMode is mapped to a value from 0-100, this can be application-specific if i understand correctly.

Sure, but I don't think we should provide a "typically" statement/value when we don't actually have info on that

jmartinez-silabs · 2025-11-11T11:16:17Z

examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h

+     * @param mediumPercent Percent value for Medium mode (typically 60)
+     * @param highPercent Percent value for High/On mode (typically 100)
+     */
+    CHIP_ERROR Init(chip::Percent offPercent, chip::Percent lowPercent, chip::Percent mediumPercent, chip::Percent highPercent);


Doesn't the # of Percent "steps" depend on FanModeEnum and FanModeSequenceEnum settings?

FanModeSequenceEnum value by default 0 which means it supports all the fanModes - off,low medium,high , so application supports all fanmodes.

examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h

examples/rangehood-app/rangehood-app-common/src/LightEndpoint.cpp

examples/rangehood-app/silabs/include/CHIPProjectConfig.h

examples/rangehood-app/silabs/src/AppTask.cpp

jmartinez-silabs · 2025-11-11T13:30:15Z

examples/rangehood-app/silabs/src/AppTask.cpp

+        static_cast<uint8_t>(::chip::DeviceLayer::Silabs::SilabsPlatform::ButtonAction::ButtonPressed))
+    {
+        // Schedule fan mode toggle on CHIP stack thread to avoid direct access causing locking errors.
+        chip::DeviceLayer::PlatformMgr().ScheduleWork([](intptr_t) { RangeHoodMgr().GetExtractorHoodEndpoint().ToggleFanMode(); },


This doesn't really make sense since you use ChipLock/Unlock in the ExtractorHoodEndpoint APIs.

I am not even sure the chip task mutex defined as Recursive. It is possible that you are creating a deadlock here. Was this tested?

This is tested like if button is pressed fan mode changes on/off.
Lock/unlock added as if this ToggleFanMode called from other than chip task. Please suggest the correct way of doing this kind of handling.

examples/rangehood-app/silabs/src/RangeHoodManager.cpp

cursor · 2025-11-11T16:58:15Z

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

+                                     to_underlying(fanModeStatus)));
+
+    // Don't update PercentCurrent if fan mode is Auto
+    VerifyOrReturnValue(currentFanMode != FanControl::FanModeEnum::kAuto, Status::Success);


Bug: Smart Mode: Automatic Control Broken

The HandlePercentSettingChange function only checks for kAuto mode before updating PercentCurrent, but HandleFanModeChange treats both kAuto and kSmart modes identically. This inconsistency means PercentCurrent will be updated when in kSmart mode even though it shouldn't be, since Smart mode should control the fan speed automatically like Auto mode.

examples/rangehood-app/silabs/src/DataModelCallbacks.cpp

Copilot

Pull Request Overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated no new comments.

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

examples/rangehood-app/silabs/src/AppTask.cpp

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

Copilot

Pull Request Overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated no new comments.

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

cursor · 2025-11-13T10:19:26Z

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

+                                     "ExtractorHoodEndpoint::SetPercentCurrent: failed to update PercentCurrent attribute: %d",
+                                     to_underlying(setStatus)));
+    return Status::Success;
+}


Bug: Nested Lock Acquisition Causes Deadlock

SetPercentCurrent() acquires the chip stack lock multiple times, but it's called from HandleFanModeChange() which is invoked from MatterPostAttributeChangeCallback where the lock is already held. This causes a deadlock. The lock/unlock calls need to be removed as the calling context already holds the lock.

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

cursor · 2025-11-13T10:19:26Z

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

+                                     "ExtractorHoodEndpoint::UpdateFanModeAttribute: failed to update FanMode attribute: %d",
+                                     to_underlying(setStatus)));
+    return Status::Success;
+}


Bug: Double Lock Deadlock

UpdateFanModeAttribute() acquires the chip stack lock, but it's called from ToggleFanMode() which is invoked via ScheduleWork where the lock is already held, and from HandleFanModeChange() which is called from MatterPostAttributeChangeCallback where the lock is already held. This causes a deadlock. The lock/unlock calls need to be removed.

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

cursor · 2025-11-13T13:27:36Z

examples/rangehood-app/silabs/src/AppTask.cpp

+#endif
+
+    // Initialization of RangeHoodManager and endpoints of range hood.
+    RangeHoodManager::GetInstance().Init();


Bug: Initialization Failures: A Silent Path to Instability

RangeHoodManager::GetInstance().Init() return value is not checked. If initialization fails (e.g., if mExtractorHoodEndpoint.Init() returns an error), the application continues running with an uninitialized state, which could lead to undefined behavior when the endpoints are used. Other similar initialization code in the codebase checks the return value and calls appError() on failure.

Copilot

Pull Request Overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated 3 comments.

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

cursor · 2025-11-13T14:11:32Z

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp

+        (currentFanMode == FanControl::FanModeEnum::kOff) ? FanControl::FanModeEnum::kHigh : FanControl::FanModeEnum::kOff;
+
+    return UpdateFanModeAttribute(target);
+}


Bug

ToggleFanMode() calls GetFanMode() and UpdateFanModeAttribute() without holding the CHIP stack lock. The GetFanMode() function explicitly requires the caller to hold the lock (per its documentation comment), and UpdateFanModeAttribute() accesses Matter attributes which also require lock protection. This causes a race condition when the function is invoked via ScheduleWork from the button handler.

bhmanda-silabs added 4 commits October 27, 2025 20:50

Added rangehood app

fa46be1

Cleanedup rangehoodapp

d1ba54b

Resolved build errors

198abad

Added fanDelegate

cf49e8d

silabs-matter-ci-bot bot added the sl-only This TAG indicates that this commit is a silabs-specific commit that cannot be upstreamed to CSA. label Oct 29, 2025

bhmanda-silabs and others added 4 commits October 29, 2025 14:28

Added button,LCD functionality to rangehood-app

cec579c

Restyled by whitespace

497571f

Restyled by clang-format

bf8f9f9

Restyled by gn

0cfc7bd

chirag-silabs reviewed Oct 30, 2025

View reviewed changes

sabollim-silabs reviewed Oct 30, 2025

View reviewed changes

bhmanda-silabs and others added 4 commits October 31, 2025 15:28

Removed speed related code

be0ec91

Removed duplicate file

9774090

Resolved review comments

10571ae

seperating common code

df0099d

sabollim-silabs force-pushed the feature/rangehood_app branch from bb74b3b to 4e4e746 Compare November 10, 2025 11:01

restruncturing

993bfda

sabollim-silabs force-pushed the feature/rangehood_app branch from 4e4e746 to 993bfda Compare November 10, 2025 11:03

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/include/ExtractorHoodEndpoint.h Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/silabs/include/AppEvent.h Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/silabs/include/AppEvent.h Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/silabs/include/RangeHoodManager.h Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/silabs/src/AppTask.cpp Outdated Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/silabs/src/AppTask.cpp Show resolved Hide resolved

arun-silabs reviewed Nov 10, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/include/LightEndpoint.h Outdated Show resolved Hide resolved

cursor bot reviewed Nov 11, 2025

View reviewed changes

examples/rangehood-app/silabs/BUILD.gn Outdated Show resolved Hide resolved

examples/rangehood-app/silabs/BUILD.gn Show resolved Hide resolved

examples/rangehood-app/silabs/data_model/BUILD.gn Show resolved Hide resolved

Resolved review comments

e524b0d

cursor bot reviewed Nov 11, 2025

View reviewed changes

examples/rangehood-app/silabs/data_model/BUILD.gn Show resolved Hide resolved

Resolved build errors

756eb2e

Copilot AI review requested due to automatic review settings November 11, 2025 06:38

Copilot AI reviewed Nov 11, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp Show resolved Hide resolved

examples/rangehood-app/silabs/include/CHIPProjectConfig.h Show resolved Hide resolved

examples/rangehood-app/silabs/BUILD.gn Outdated Show resolved Hide resolved

cursor bot reviewed Nov 11, 2025

View reviewed changes

arun-silabs reviewed Nov 11, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/src/LightEndpoint.cpp Outdated Show resolved Hide resolved

jmartinez-silabs requested changes Nov 11, 2025

View reviewed changes

restyled-commits added 3 commits November 11, 2025 22:22

Restyled by whitespace

929417f

Restyled by clang-format

37e6fcf

Restyled by gn

a5e77f8

cursor bot reviewed Nov 11, 2025

View reviewed changes

Resolved review comments

997a0fb

Copilot AI review requested due to automatic review settings November 13, 2025 09:01

Copilot AI reviewed Nov 13, 2025

View reviewed changes

cursor bot reviewed Nov 13, 2025

View reviewed changes

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp Show resolved Hide resolved

examples/rangehood-app/silabs/src/AppTask.cpp Outdated Show resolved Hide resolved

examples/rangehood-app/rangehood-app-common/src/ExtractorHoodEndpoint.cpp Outdated Show resolved Hide resolved

bhmanda-silabs and others added 3 commits November 13, 2025 15:37

Added construtor inplace of Init

2cdc309

Restyled by whitespace

b58eac2

Restyled by clang-format

beed203

Copilot AI review requested due to automatic review settings November 13, 2025 10:12

Copilot AI reviewed Nov 13, 2025

View reviewed changes

cursor bot reviewed Nov 13, 2025

View reviewed changes

Removed lock/unlock chipstack as it is having lock

cdff3b3

cursor bot reviewed Nov 13, 2025

View reviewed changes

Restyled by whitespace

59ca047

Copilot AI review requested due to automatic review settings November 13, 2025 14:07

Copilot AI reviewed Nov 13, 2025

View reviewed changes

cursor bot reviewed Nov 13, 2025

View reviewed changes

[SL-ONLY] Feature/rangehood app #698

Are you sure you want to change the base?

[SL-ONLY] Feature/rangehood app #698

Uh oh!

Conversation

bhmanda-silabs commented Oct 29, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related issues

Testing

Readability checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor bot Nov 11, 2025

Choose a reason for hiding this comment

Bug: Improve Fan Mode Attribute Update Efficiency

Uh oh!

Uh oh!

jmartinez-silabs commented Nov 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhmanda-silabs Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

bhmanda-silabs commented Oct 29, 2025 •

edited by cursor bot

Loading

bhmanda-silabs Nov 13, 2025 •

edited

Loading