chore(deps): upgrade Tomlyn 0.19.0 -> 2.10.1#90
Merged
Conversation
Tomlyn v1/v2 is a major redesign with a System.Text.Json-style API; the static `Toml` entry point is gone. Migrate the untyped-model call sites (config, scenario, api-token, and plugin-manifest parsers): - `Toml.ToModel(s)` -> `TomlSerializer.Deserialize<TomlTable>(s) ?? new TomlTable()` - `Toml.FromModel(m)` -> `TomlSerializer.Serialize(m)` `TomlTable` / `TomlTableArray` (Tomlyn.Model) and `TomlException` are unchanged, so the model access and syntax-error handling stay as-is. Tomlyn v2 targets TOML 1.1; our config/scenario/token documents round-trip unchanged. Verified by the full suite (incl. 11 invalid-syntax tests) and a real-binary config add/list round-trip. Lock files refreshed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the Tomlyn major upgrade that Dependabot could not land (its build failed against the v2 API).
Why it broke
Tomlyn v1/v2 is a major redesign — a
System.Text.Json-style API (TomlSerializer, source generation, TOML 1.1). The staticTomlentry point (Toml.ToModel/Toml.FromModel) is gone.What
Migrate the four untyped-model call sites — config, scenario, api-token, and plugin-manifest parsers:
Toml.ToModel(s)→TomlSerializer.Deserialize<TomlTable>(s) ?? new TomlTable()Toml.FromModel(m)→TomlSerializer.Serialize(m)TomlTable/TomlTableArray(Tomlyn.Model) andTomlExceptionare unchanged, so model access and syntax-error handling stay as-is.Verification
TomlExceptioncatch path.visa add→visa listconfig round-trip works (write + read through Tomlyn v2).--locked-moderestore passes; lock files refreshed; CSharpier clean.TOML 1.1 (v2) is a superset of the 1.0 features these documents use, so no config/scenario changes are needed. Version bump + CHANGELOG will be aggregated in the next release PR.