removed depreciation from consignment apis #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamal0808
reviewed
Sep 12, 2023
lib/consignment.js
Outdated
|
|
||
| return utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter); | ||
| const getOrdersFromSuppliers = utils.sendRequest(options, args, connectionInfo, fetchStockOrdersForSuppliers, retryCounter); | ||
| const result = getOrdersFromSuppliers?.data ? getOrdersFromSuppliers?.data : getOrdersFromSuppliers; |
There was a problem hiding this comment.
getOrdersFromSuppliers?.data || getOrdersFromSuppliers
kamal0808
approved these changes
Sep 12, 2023
kamal0808
reviewed
Sep 12, 2023
| } | ||
|
|
||
| var path = '/api/1.0/consignment/' + args.apiId.value; | ||
| var path = '/api/2.0/consignments/' + args.apiId.value; |
There was a problem hiding this comment.
have you considered creating a new path instead of replacing the existing ones?
|
@chronos25 this can be merged. |
kamal0808
reviewed
Sep 29, 2023
lib/consignment.js
Outdated
|
|
||
| var path = '/api/consignment_product'; | ||
| var path = `/api/2.0/consignments/${args.consignmentId.value}/products`; | ||
| //var path = '/api/consignment_product'; |
There was a problem hiding this comment.
Remove this commented code before merging, or add the deprecation notice URL in the comment somewhere with reason @chronos25
kamal0808
approved these changes
Feb 19, 2024
| return utils.sendRequest(options, args, connectionInfo, fetchProductsByConsignment, retryCounter); | ||
| return utils.sendRequest(options, args, connectionInfo, fetchProductsByConsignment, retryCounter) | ||
| .then(function(response){ | ||
| return response.data; |
|
|
||
| var path = '/api/consignment_product'; | ||
| var path = `/api/2.0/consignments/${args.body.consignment_id}/products`; | ||
| //var path = '/api/consignment_product'; |
There was a problem hiding this comment.
get rid of commented code or add reason for commenting
| return Promise.reject(error); | ||
| } | ||
| return Promise.resolve(response); | ||
| return Promise.resolve(response.data); |
lib/consignment.js
Outdated
| return utils.sendRequest(options, args, connectionInfo, createStockOrder, retryCounter) | ||
| .then(function(response){ | ||
| return response.data; | ||
| }); |
| return utils.sendRequest(options, args, connectionInfo, updateConsignmentProduct, retryCounter); | ||
| return utils.sendRequest(options, args, connectionInfo, updateConsignmentProduct, retryCounter) | ||
| .then(function(response){ | ||
| return response.data; |
| return utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter); | ||
| return utils.sendRequest(options, args, connectionInfo, markStockOrderAsSent, retryCounter) | ||
| .then(function(response){ | ||
| return response.data; |
| return utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter); | ||
| return utils.sendRequest(options, args, connectionInfo, markStockOrderAsReceived, retryCounter) | ||
| .then(function(response){ | ||
| return response.data; |
lib/consignment.js
Outdated
| return utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter); | ||
| return utils.sendRequest(options, args, connectionInfo, deleteStockOrder, retryCounter) | ||
| .then(function(response){ | ||
| return response.data; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.