Skip to content

Conversation

@o-benz
Copy link

@o-benz o-benz commented Jan 9, 2026

What are you trying to accomplish?

Relates to shop/issues-addresses#647

ONLY MERGE AFTER #415

Postal codes starting with 0 are valid in Luxembourg and are used for packstation/parcel locker services (e.g., 0692). Updated regex from [1-9]\d{3} to \d{4} to allow these codes.

What approach did you choose and why?

I updated the LU zip_regex (and matching partial_zip_regex).

What should reviewers focus on?

The updated regex and the new regression tests, especially that valid formats still pass and bad ones still fail.

The impact of these changes

Valid LU postcodes that were previously rejected will now be accepted. Valid LU postcodes should remain unaffected.

Testing

Added test/worldwide/regions/lu_test.rb covering valid LU outward formats and rejecting the invalid cases.

Next Steps

Checklist

  • I have added a CHANGELOG entry for this change (or determined that it isn't needed)

o-benz added 2 commits January 9, 2026 13:49
Postal codes starting with 0 are valid in Luxembourg and are used for
packstation/parcel locker services (e.g., 0692). Updated regex from
[1-9]\d{3} to \d{4} to allow these codes.

Fixes shop/issues-addresses#647
@o-benz o-benz requested review from a team and gabypancu January 9, 2026 18:58
@o-benz o-benz self-assigned this Jan 9, 2026
@o-benz o-benz mentioned this pull request Jan 9, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant