Fix LU postal code regex to allow zero as first digit #417
+41
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Relates to shop/issues-addresses#647
ONLY MERGE AFTER #415
Postal codes starting with 0 are valid in Luxembourg and are used for packstation/parcel locker services (e.g., 0692). Updated regex from [1-9]\d{3} to \d{4} to allow these codes.
What approach did you choose and why?
I updated the LU zip_regex (and matching partial_zip_regex).
What should reviewers focus on?
The updated regex and the new regression tests, especially that valid formats still pass and bad ones still fail.
The impact of these changes
Valid LU postcodes that were previously rejected will now be accepted. Valid LU postcodes should remain unaffected.
Testing
Added
test/worldwide/regions/lu_test.rbcovering valid LU outward formats and rejecting the invalid cases.Next Steps
Checklist