Skip to content

Update definitions as part of admin-ui-* release #3145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 2025-10-rc
Choose a base branch
from
Open

Update definitions as part of admin-ui-* release #3145

wants to merge 2 commits into from

Conversation

gwyneplaine
Copy link
Contributor

Background

(Provide a link to any relevant issues AND provide a TLDR of the issue in this pull request)

Solution

(Describe your solution, why this approach was chosen, and what the alternatives/impacts may be)

🎩

  • ...

Checklist

  • I have 🎩'd these changes
  • I have updated relevant documentation

@gwyneplaine Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gwyneplaine
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @gwyneplaine! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/ui-extensions": "0.0.0-snapshot-20250814063915"

@gwyneplaine gwyneplaine marked this pull request as ready for review August 14, 2025 06:49
sam-b-rose
sam-b-rose reviewed Aug 14, 2025
View reviewed changes
packages/ui-extensions/src/surfaces/admin/components/Choice.d.ts
>
> {}
> {
label: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyledurand is this correct or will this be gone in the next update?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to remove this

sam-b-rose
sam-b-rose approved these changes Aug 14, 2025
View reviewed changes
Copy link
Member

@sam-b-rose sam-b-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just curious about the changes to Choice (I don't label should be a property, just a slot)

@gwyneplaine gwyneplaine force-pushed the clee/color-components branch from f8e1602 to c85a89b Compare August 15, 2025 02:16
@gwyneplaine
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @gwyneplaine! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/ui-extensions": "0.0.0-snapshot-20250815021939"

@gwyneplaine
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @gwyneplaine! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/ui-extensions": "0.0.0-snapshot-20250815053250"

@gwyneplaine
Copy link
Contributor Author

/snapit

@shopify-github-actions-access
Copy link
Contributor

🫰✨ Thanks @gwyneplaine! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

"@shopify/ui-extensions": "0.0.0-snapshot-20250818171948"

@sam-b-rose
Copy link
Member

@gwyneplaine I've update the component types, but I don't think the SharedComponents.ts was updated. Rebase on 2025-10-rc to verify any new changes that might still be need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyledurand kyledurand kyledurand left review comments

@sam-b-rose sam-b-rose sam-b-rose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gwyneplaine @sam-b-rose @kyledurand