Logging API #93
Closed
Logging API #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's one possible approach for exposing a logging API that doesn't use standard error. The logs are stored in a thread local singleton value and a function is exported from the provider to get the index into memory to get the singleton. The host provider can choose to read some or all of the buffer and render it to a UTF-8 string.
The nice thing with this approach is we can skip performing a number of checks for null pointers or performing length/capacity checks while logging outside of what the underlying vector performs.
One messy part of this approach is the need to offer an API for use by unit tests to reset the logging state.