Clean up cancelled requests after processing them#3971
Open
Clean up cancelled requests after processing them#3971
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
bugfix
Graphite App
alexcrocha
reviewed
Feb 21, 2026
|
|
||
| process_message(message) | ||
| # Ensure we remove the request if it got cancelled while it was being processed | ||
| @cancelled_requests.delete(id) |
Contributor
There was a problem hiding this comment.
This is now outside the @global_state.synchronize block. Does it need to be wrapped again?
Suggested change
| @cancelled_requests.delete(id) | |
| @global_state.synchronize { @cancelled_requests.delete(id) } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We were growing the cancelled requests list indefinitely when the notification came in during process. We only cleaned up if the editor managed to cancel the request before we got to it.
Implementation
We can fix the unbound memory growth by always ensuring that we delete from the list after processing.
Automated Tests
Added a test to ensure that the list is always empty after the request got processed.