Forward initialization settings to addons #2513
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1204
First step to allow Shopify/ruby-lsp-rails#389
While we work super hard to minimize the amount of configuration for the Ruby LSP, it's not realistic to assume that addons are not going to need any settings to be exposed.
We need a way to allow addons to receive relevant editor settings, so that their behaviour can be customized.
Implementation
The idea is to allow for configuration objects like
And then we remember those settings in the global state. Addons will then have access to these settings and can decide what to do accordingly.
Automated Tests
Added tests.