-
Notifications
You must be signed in to change notification settings - Fork 34
Add CLAUDE.md for LLM agent assistance #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While /init
usually does a good job getting the overview, it still makes quite a bit of mistakes. Can you actually review the content and verify that everything it says is correct AND necessary?
Oops, I had meant to open as a draft PR. I've pushed some updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a symlink for .github/copilot-instructions.md
, similar to what we did in the LSP.
Also, I think it might be worth going into a bit more detail about the architecture. For example, how the add-on communicates with the runtime and what's the responsibility of each side
bcd2c64
to
89ada8f
Compare
I think it may be better to add that when actually working on a feature, to allow for experimentation and iteration. WDYT? |
|
||
## Architecture | ||
|
||
### Core Components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main doubts are regarding this section. Here we mention both the add-on system and the runner client/server without providing any explanations about what they are and how they relate to editor features.
Is this information without any additional context going to yield better generation results?
Under Architecture
, before we start describing the code structure and what file contains what, let's add some content explaining:
- What is the add-on system and how it allows to enhance features that belong to the LSP specification
- That we have a runtime component which communicates with a minimal Rails server using JSON RPC (implemented in client/server files)
- That we try to provide as many features as possible with static analysis only, but leverage the runtime component to augment what we can provide
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
Co-authored-by: Vinicius Stock <[email protected]>
Inspired by Shopify/ruby-lsp#3668
This is exactly as generated by
/init
.