-
Notifications
You must be signed in to change notification settings - Fork 33
Enhance schema hover link to jump to the right table #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 10 commits
60cc1fe
abe9229
77da138
e3f748f
3d9b762
63bf2c1
da54d63
4d97874
5f65cb9
633edc5
0e414a7
c24d3d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
# typed: strict | ||
# frozen_string_literal: true | ||
|
||
module RubyLsp | ||
module Rails | ||
class SchemaCollector < Prism::Visitor | ||
extend T::Sig | ||
|
||
sig { returns(T::Hash[String, Prism::Location]) } | ||
attr_reader :tables | ||
|
||
sig { params(project_root: Pathname).void } | ||
def initialize(project_root) | ||
super() | ||
|
||
@tables = T.let({}, T::Hash[String, Prism::Location]) | ||
@schema_path = T.let(project_root.join("db", "schema.rb").to_s, String) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This isn't quite right as some apps use If you search you'll see we use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This means this collector will need to communicate with the server. The path for the schema is unlikely to change, so maybe there's room for a refactor where we fetch the schema path once and reuse it here and in hover. Maybe we can move forward with this and simply not populate anything if |
||
end | ||
|
||
sig { void } | ||
def parse_schema | ||
parse_result = Prism.parse_file(@schema_path) | ||
parse_result.value.accept(self) | ||
end | ||
|
||
sig { params(node: Prism::CallNode).void } | ||
def visit_call_node(node) | ||
if node.message == "create_table" | ||
first_argument = node.arguments&.arguments&.first | ||
|
||
if first_argument&.is_a?(Prism::StringNode) | ||
@tables[first_argument.content] = node.location | ||
end | ||
end | ||
|
||
super | ||
end | ||
end | ||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
# typed: true | ||
# frozen_string_literal: true | ||
|
||
require "test_helper" | ||
|
||
SCHEMA_FILE = <<~RUBY | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's move this into |
||
ActiveRecord::Schema[7.1].define(version: 2023_12_09_114241) do | ||
create_table "cats", force: :cascade do |t| | ||
end | ||
|
||
create_table "dogs", force: :cascade do |t| | ||
end | ||
end | ||
RUBY | ||
|
||
module RubyLsp | ||
module Rails | ||
class SchemaCollectorTest < ActiveSupport::TestCase | ||
test "store locations of models by parsing create_table calls" do | ||
collector = RubyLsp::Rails::SchemaCollector.new(Pathname.new("example_app")) | ||
Prism.parse(SCHEMA_FILE).value.accept(collector) | ||
|
||
assert_equal(["cats", "dogs"], collector.tables.keys) | ||
end | ||
end | ||
end | ||
end |
Uh oh!
There was an error while loading. Please reload this page.