Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #169
buildStyleinsrc/composeRestyleFunctions.tsnow skips keys that have no Restyle function, instead of crashing withTypeError: funcsMap[propKey] is not a function.filterRestylePropsalready treats unknown component props the same way.Since 2.1.0,
useRestylesetsvariantto'defaults'on every render, socreateVariantalways callsbuildStyle. Two inputs give it keys with no Restyle function:textVariants, or the component renders outside aThemeProvider.'defaults'does not resolve, andcreateVariantspreads the string into the keys0,1,2and so on. A minimal theme withcreateTexthits this.transform.Two judgement calls:
buildStylebecause that is the crash site and it covers both inputs and all callers. A narrower fix increateVariantis possible if you prefer it.Reviewers' hat-rack 🎩
createTextrenders when the theme has notextVariants.transform) renders its Restyle props and ignores the other prop.createText.test.tsxandcreateVariant.test.tsfail onmasterwith the reported error.Screenshots or videos (if needed)
Not applicable. Jest tests cover the change.
Checklist