Updating to typescript 3.2 #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
changed the title
|
This is rebased atop latest master and is now ready for review |
AndrewMusgrave
approved these changes
May 2, 2019
The last release of typescript-eslint-parser is 22.0.0 which only supports up to TS 3.2.x. We're stuck on this because eslint-plugin-shopify still uses typescript-eslint-parser and has not yet moved onto its replacement package @typescript-eslint/parser - which supports TS 3.2.x and above. Somehow among all this we now get false positives for violations of the import/named rule. It's fine to disable that as TS will shout at us if we reference an unknown import anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Consumers can't move past typescript 3.1.6 thanks to us erroring in those versions
WHAT is this pull request doing?
Updating to typescript 3.2.4
Shopify/quilt#602 shows how quilt and react-compose were able to compile in TS 3.2, hopefully similar fixes should do the job in our HoCs but my TS-fu isn't up to the task
Thanks to conflicting version dependencies with our linting tools we can't go all the way up to 3.4:
The last release of typescript-eslint-parser is 22.0.0 which only
supports up to TS 3.2.x. We're stuck on this because
eslint-plugin-shopify still uses typescript-eslint-parser and has not
yet moved onto its replacement package @typescript-eslint/parser - which
supports TS 3.2.x and above.
Somehow among all this we now get false positives for violations of the
import/named rule. It's fine to disable that as TS will shout at us if
we reference an unknown import anyway.
Let's stick with 3.2.x for the moment, and then when eslint-plugin-shopify updates to use typescript-eslint-parser we can update beyond that
How to 🎩
yarn run sk type-check