Repository navigation
Add Dev Instance support to hydrogen dev - #4272
Open
gonzaloriestra wants to merge 5 commits into
Open
gonzaloriestra wants to merge 5 commits into
gonzaloriestra wants to merge 5 commits into
Conversation
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-preview-instances
branch
2 times, most recently
from
October 27, 2026 12:46
e75aaa2 to
e0d0333
Compare
gonzaloriestra
marked this pull request as ready for review
October 27, 2026 13:32
This comment has been minimized.
This comment has been minimized.
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-preview-instances
branch
8 times, most recently
from
October 27, 2026 17:03
424377d to
cc3eb1e
Compare
fredericoo
requested changes
Oct 27, 2026
5 tasks done
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-preview-instances
branch
2 times, most recently
from
October 28, 2026 10:23
6fc5a83 to
3c0abef
Compare
fredericoo
approved these changes
Oct 28, 2026
gonzaloriestra
force-pushed
the
gonzalo/hydrogen-dev-preview-instances
branch
from
October 28, 2026 15:06
3c0abef to
2bd6625
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Agents cannot discover a running
hydrogen devsession or read its output after it starts in another terminal. Part of https://github.com/shop/issues-develop/issues/24321, following Shopify/cli#8976.WHAT is this pull request doing?
Use CLI Kit's Dev Instance API to record readiness, URLs, and JSONL logs under the project's
.shopify/dev/directory. Ownership uses the command, project, environment, environment branch, and environment file, so changing the port does not allow a duplicate session.Capture runtime output while keeping terminal rendering. Exclude session files from file-change logs to prevent feedback loops. Stop owned resources and drain queued logs on startup failure, Ctrl+C, SIGTERM, or lost ownership. Cancel tunnel polling, authentication, storefront prompts, token polling, and environment loading on shutdown or another startup failure. Persist newly created storefronts before honoring cancellation, so the next run reuses their link. Preserve the previous project config if storefront provisioning fails. Wait for startup, config writes, and resource cleanup to settle before releasing ownership. Preserve Admin API network retries when passing a cancellation signal. Restore previous Customer Account URLs if setup is cancelled after the update or saving local config fails. Key symlinked projects by the env file they actually load. Describe session discovery and lifecycle behavior in command help and update the manifest.
Pin CLI Kit to
5.0.0for the Dev Instance API, including the bundled dependency increate-hydrogen.HOW to test your changes?
pnpm patch-cliafter building).pnpm shopify hydrogen dev --path /path/to/projectagainst an existing Hydrogen project. Read the matching instance JSON in its.shopify/dev/directory and follow itslogFile. Confirm the status becomesrunningand URLs appear.Checklist