Skip to content

Refactor metrics emitter interface#41

Merged
forge33 merged 1 commit into
pb/emit_rep_hb_lag_metricsfrom
pb/refactor_metrics_emitter
Jun 3, 2026
Merged

Refactor metrics emitter interface#41
forge33 merged 1 commit into
pb/emit_rep_hb_lag_metricsfrom
pb/refactor_metrics_emitter

Conversation

@forge33
Copy link
Copy Markdown

@forge33 forge33 commented Jun 1, 2026 •
edited
Loading

Related issue: github#1672

Description

  • Rename the metrics test/client abstraction to Emitter.
  • Collapse gauge, count, and histogram methods into one interface used by MigrationContext.Metrics.
  • Update existing metric helpers and tests to use the unified interface.

🎩

Tophatted as part of #42 #45 #46 #47

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@forge33
Refactor metrics emitter interface
9b8cb09 
Use a single metrics emitter abstraction for gauge, count, and histogram samples so metric helpers share one testable client contract.
@forge33 forge33 added the #gsd:50633 Data Storage: gh-ost Observability Instrumentation label Jun 1, 2026
@grodowski grodowski mentioned this pull request Jun 2, 2026
Closed
@forge33 forge33 merged commit 5fc06a4 into pb/emit_rep_hb_lag_metrics Jun 3, 2026
6 checks passed
@forge33 forge33 mentioned this pull request Jun 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grodowski grodowski grodowski approved these changes

Assignees

No one assigned

Labels

#gsd:50633 Data Storage: gh-ost Observability Instrumentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@forge33 @grodowski