Update discount example #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devisscher
force-pushed
the
update-discount-example
branch
4 times, most recently
from
64bdf1a to
5ca7e06
Compare
davejcameron
reviewed
May 5, 2025
|
I think we might need to update https://github.com/Shopify/function-examples/blob/main/discounts/rust/discount/default/shopify.extension.toml.liquid as well with the new target name |
hamishmorgan
reviewed
May 7, 2025
| @@ -9,14 +9,14 @@ description = "t:description" | |||
|
|
|||
| [[extensions.targeting]] | |||
| target = "cart.lines.discounts.generate.run" | |||
| input_query = "src/generate_cart_run.graphql" | |||
| export = "generate-cart-run" | |||
| input_query = "src/cart_lines_discounts_generate_run.graphql" | |||
There was a problem hiding this comment.
I notice you didn't bump the api_version in this file. Is that an oversight?
There was a problem hiding this comment.
To unstable or 2025-07?
There was a problem hiding this comment.
I put the rust one on 2025-04 as well.
devisscher
force-pushed
the
update-discount-example
branch
from
453944a to
113321f
Compare
jonathanhamel4
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the discount examples to simplify exports and renames files to match target names.