Skip to content

Add shopify feedback command, bumping app_cli3_command to 1.29 - #8352

Draft
egaodd wants to merge 1 commit into
mainfrom
08-19-add_shopify_feedback_command_bumping_app_cli3_command_to_1.29
Draft

Add shopify feedback command, bumping app_cli3_command to 1.29#8352
egaodd wants to merge 1 commit into
mainfrom
08-19-add_shopify_feedback_command_bumping_app_cli3_command_to_1.29

Conversation

@egaodd

@egaodd egaodd commented Aug 19, 2026

Copy link
Copy Markdown

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

egaodd commented Aug 19, 2026

Copy link
Copy Markdown
Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label Aug 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/metadata.d.ts
@@ -34,7 +34,7 @@ export type SensitiveSchema<T> = T extends RuntimeMetadataManager<infer _TPublic
  * @returns A container for the metadata.
  */
 export declare function createRuntimeMetadataContainer<TPublic extends AnyJson, TSensitive extends AnyJson = Record<string, never>>(defaultPublicMetadata?: Partial<TPublic>): RuntimeMetadataManager<TPublic, TSensitive>;
-type CmdFieldsFromMonorail = PickByPrefix<MonorailEventPublic, 'cmd_all_'> & PickByPrefix<MonorailEventPublic, 'cmd_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_create_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_theme_'> & PickByPrefix<MonorailEventPublic, 'store_'> & PickByPrefix<MonorailEventPublic, 'env_auto_upgrade_'>;
+type CmdFieldsFromMonorail = PickByPrefix<MonorailEventPublic, 'cmd_all_'> & PickByPrefix<MonorailEventPublic, 'cmd_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_create_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_theme_'> & PickByPrefix<MonorailEventPublic, 'cmd_feedback_'> & PickByPrefix<MonorailEventPublic, 'store_'> & PickByPrefix<MonorailEventPublic, 'env_auto_upgrade_'>;
 declare const coreData: RuntimeMetadataManager<CmdFieldsFromMonorail, {
     commandStartOptions: {
         startTime: number;
@@ -46,6 +46,7 @@ declare const coreData: RuntimeMetadataManager<CmdFieldsFromMonorail, {
     };
 } & {
     environmentFlags: string;
+    cmd_feedback_message: string;
 } & PickByPrefix<{
     args: string;
     error_message?: string | null;
@@ -68,6 +69,7 @@ export declare const getAllPublicMetadata: () => Partial<CmdFieldsFromMonorail>,
     };
 } & {
     environmentFlags: string;
+    cmd_feedback_message: string;
 } & PickByPrefix<{
     args: string;
     error_message?: string | null;
@@ -89,6 +91,7 @@ export declare const getAllPublicMetadata: () => Partial<CmdFieldsFromMonorail>,
     };
 } & {
     environmentFlags: string;
+    cmd_feedback_message: string;
 } & PickByPrefix<{
     args: string;
     error_message?: string | null;
packages/cli-kit/dist/public/node/monorail.d.ts
@@ -2,7 +2,7 @@ import { JsonMap } from '../../private/common/json.js';
 import { DeepRequired } from '../common/ts/deep-required.js';
 export { DeepRequired };
 type Optional<T> = T | null;
-export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.28";
+export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.29";
 export interface Schemas {
     [MONORAIL_COMMAND_TOPIC]: {
         sensitive: {
@@ -102,6 +102,11 @@ export interface Schemas {
             cmd_deploy_config_modules_added?: Optional<string>;
             cmd_deploy_config_modules_deleted?: Optional<string>;
             cmd_release_confirm_cancelled?: Optional<boolean>;
+            cmd_feedback_sentiment?: Optional<string>;
+            cmd_feedback_category?: Optional<string>;
+            cmd_feedback_message_length?: Optional<number>;
+            cmd_feedback_message_truncated?: Optional<boolean>;
+            cmd_feedback_source?: Optional<string>;
             app_extensions_any?: Optional<boolean>;
             app_extensions_breakdown?: Optional<string>;
             app_extensions_count?: Optional<number>;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant