Add shopify feedback command, bumping app_cli3_command to 1.29 - #8352
Draft
egaodd wants to merge 1 commit into
Draft
Add shopify feedback command, bumping app_cli3_command to 1.29#8352egaodd wants to merge 1 commit into
egaodd wants to merge 1 commit into
Conversation
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/metadata.d.ts@@ -34,7 +34,7 @@ export type SensitiveSchema<T> = T extends RuntimeMetadataManager<infer _TPublic
* @returns A container for the metadata.
*/
export declare function createRuntimeMetadataContainer<TPublic extends AnyJson, TSensitive extends AnyJson = Record<string, never>>(defaultPublicMetadata?: Partial<TPublic>): RuntimeMetadataManager<TPublic, TSensitive>;
-type CmdFieldsFromMonorail = PickByPrefix<MonorailEventPublic, 'cmd_all_'> & PickByPrefix<MonorailEventPublic, 'cmd_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_create_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_theme_'> & PickByPrefix<MonorailEventPublic, 'store_'> & PickByPrefix<MonorailEventPublic, 'env_auto_upgrade_'>;
+type CmdFieldsFromMonorail = PickByPrefix<MonorailEventPublic, 'cmd_all_'> & PickByPrefix<MonorailEventPublic, 'cmd_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_create_app_'> & PickByPrefix<MonorailEventPublic, 'cmd_theme_'> & PickByPrefix<MonorailEventPublic, 'cmd_feedback_'> & PickByPrefix<MonorailEventPublic, 'store_'> & PickByPrefix<MonorailEventPublic, 'env_auto_upgrade_'>;
declare const coreData: RuntimeMetadataManager<CmdFieldsFromMonorail, {
commandStartOptions: {
startTime: number;
@@ -46,6 +46,7 @@ declare const coreData: RuntimeMetadataManager<CmdFieldsFromMonorail, {
};
} & {
environmentFlags: string;
+ cmd_feedback_message: string;
} & PickByPrefix<{
args: string;
error_message?: string | null;
@@ -68,6 +69,7 @@ export declare const getAllPublicMetadata: () => Partial<CmdFieldsFromMonorail>,
};
} & {
environmentFlags: string;
+ cmd_feedback_message: string;
} & PickByPrefix<{
args: string;
error_message?: string | null;
@@ -89,6 +91,7 @@ export declare const getAllPublicMetadata: () => Partial<CmdFieldsFromMonorail>,
};
} & {
environmentFlags: string;
+ cmd_feedback_message: string;
} & PickByPrefix<{
args: string;
error_message?: string | null;
packages/cli-kit/dist/public/node/monorail.d.ts@@ -2,7 +2,7 @@ import { JsonMap } from '../../private/common/json.js';
import { DeepRequired } from '../common/ts/deep-required.js';
export { DeepRequired };
type Optional<T> = T | null;
-export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.28";
+export declare const MONORAIL_COMMAND_TOPIC = "app_cli3_command/1.29";
export interface Schemas {
[MONORAIL_COMMAND_TOPIC]: {
sensitive: {
@@ -102,6 +102,11 @@ export interface Schemas {
cmd_deploy_config_modules_added?: Optional<string>;
cmd_deploy_config_modules_deleted?: Optional<string>;
cmd_release_confirm_cancelled?: Optional<boolean>;
+ cmd_feedback_sentiment?: Optional<string>;
+ cmd_feedback_category?: Optional<string>;
+ cmd_feedback_message_length?: Optional<number>;
+ cmd_feedback_message_truncated?: Optional<boolean>;
+ cmd_feedback_source?: Optional<string>;
app_extensions_any?: Optional<boolean>;
app_extensions_breakdown?: Optional<string>;
app_extensions_count?: Optional<number>;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add