Skip to content

[Feature] Add intercepts target capability support #8345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
henryStelle wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −3
Draft

[Feature] Add intercepts target capability support #8345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/add-intercepts-capability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/app': minor
---

Add support for the `intercepts` UI extension target capability.
1 change: 1 addition & 0 deletions packages/app/src/cli/models/extensions/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export const ExtensionsArraySchema = zod.object({

const TargetCapabilitiesSchema = zod.object({
allow_direct_linking: zod.boolean().optional(),
intercepts: zod.any().optional(),
})

const ShouldRenderSchema = zod.object({
Expand Down
14 changes: 11 additions & 3 deletions packages/app/src/cli/models/extensions/specifications/ui_extension.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,15 +241,23 @@ describe('ui_extension', async () => {
])
})

test('targeting object accepts allow_direct_linking for target capabilities', async () => {
test('targeting object accepts typed and arbitrary JSON target capabilities', async () => {
const allSpecs = await loadLocalExtensionsSpecifications()
const specification = allSpecs.find((spec) => spec.identifier === 'ui_extension')!
const intercepts = [
{
event: 'paymentvalidations',
blocking: true,
applies_to: ['cash'],
future_options: {enabled: true, values: ['one', 2, null]},
},
]
const configuration = {
targeting: [
{
target: 'EXTENSION::POINT::A',
module: './src/ExtensionPointA.js',
capabilities: {allow_direct_linking: true},
capabilities: {allow_direct_linking: true, intercepts},
},
],
api_version: '2023-01' as const,
Expand Down Expand Up @@ -292,7 +300,7 @@ describe('ui_extension', async () => {
metafields: [],
urls: {},
default_placement_reference: undefined,
capabilities: {allow_direct_linking: true},
capabilities: {allow_direct_linking: true, intercepts},
preloads: {},
build_manifest: {
assets: {
Expand Down
Loading