Skip to content

Use API discovery for E2E store cleanup#8053

Merged
alfonso-noriega merged 1 commit into
mainfrom
e2e-api-store-cleanup
Jul 10, 2026
Merged

Use API discovery for E2E store cleanup#8053
alfonso-noriega merged 1 commit into
mainfrom
e2e-api-store-cleanup

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #0000

E2E cleanup can leak development stores when per-test teardown skips store deletion because apps are still installed. The final cleanup job was also discovering stores by scrolling and scraping the Dev Dashboard UI, which has been observed loading hundreds/thousands of rows while finding zero current-run stores.

WHAT is this pull request doing?

  • Primes cleanup auth for both CLI Business Platform requests and Playwright browser state.
  • Discovers matching app development stores through Business Platform GraphQL before falling back to Dev Dashboard UI scraping.
  • Runs final current-run app cleanup before current-run store cleanup so stores are more likely to be empty when deletion runs.

No changeset: this is internal CI/E2E maintenance only.

How to test your changes?

  • pnpm nx run e2e:type-check --skip-nx-cache
  • pnpm nx run e2e:lint --skip-nx-cache
  • pnpm nx run cli:build --skip-nx-cache
  • pnpm --filter e2e exec tsx --eval "Promise.all([import('./scripts/cleanup-stores.ts'), import('./scripts/prime-browser-auth.ts')]).then(() => console.log('script imports ok'))"

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add (not applicable: internal CI cleanup)

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 10, 2026 09:54

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 10, 2026
@alfonso-noriega alfonso-noriega force-pushed the e2e-api-store-cleanup branch 2 times, most recently from 313d743 to 723c8b7 Compare July 10, 2026 10:39
Assisted-By: devx/cb4fb0f6-10a0-483b-9fb5-8346a8482c19
@alfonso-noriega alfonso-noriega force-pushed the e2e-api-store-cleanup branch from 723c8b7 to fd75233 Compare July 10, 2026 12:13
@alfonso-noriega alfonso-noriega added this pull request to the merge queue Jul 10, 2026
Merged via the queue into main with commit 02a1080 Jul 10, 2026
28 of 29 checks passed
@alfonso-noriega alfonso-noriega deleted the e2e-api-store-cleanup branch July 10, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants