Clean up current-run E2E dev stores#7978
Open
alfonso-noriega wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
gonzaloriestra
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
After E2E shards finish, CI currently runs a current-run app cleanup job, but dev stores are only cleaned by each test's best-effort teardown. If a teardown is interrupted or flakes, stores can remain behind.
WHAT is this pull request doing?
Adds current-run dev store cleanup to the post-E2E cleanup job, before app cleanup, using the run token added in the parent PR. Store cleanup now also reuses the primed Playwright browser storage state, matching app cleanup and avoiding an extra Shopify Accounts login when possible.
The cleanup job now checks out
github.shafrom the base repository instead of ephemeral PR/merge-queue head refs, so cleanup is less likely to fail before running when temporary refs disappear.How to test your changes?
cd packages/e2e && pnpm tsc --noEmitcd packages/e2e && pnpm eslint "setup/**/*.ts" "helpers/**/*.ts" "tests/**/*.ts" "*.ts"node bin/run-knip-ci.jsNote: ESLint completed successfully with existing Nx project graph cache warnings for
@nx/enforce-module-boundaries. The PR E2E cleanup job will exercise the workflow path in CI.Post-release steps
None.
Checklist