Skip to content

Clean up current-run E2E dev stores#7978

Open
alfonso-noriega wants to merge 1 commit into
07-01-e2e_store_run_tokenfrom
07-01-e2e_store_cleanup_job
Open

Clean up current-run E2E dev stores#7978
alfonso-noriega wants to merge 1 commit into
07-01-e2e_store_run_tokenfrom
07-01-e2e_store_cleanup_job

Conversation

@alfonso-noriega

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

After E2E shards finish, CI currently runs a current-run app cleanup job, but dev stores are only cleaned by each test's best-effort teardown. If a teardown is interrupted or flakes, stores can remain behind.

WHAT is this pull request doing?

Adds current-run dev store cleanup to the post-E2E cleanup job, before app cleanup, using the run token added in the parent PR. Store cleanup now also reuses the primed Playwright browser storage state, matching app cleanup and avoiding an extra Shopify Accounts login when possible.

The cleanup job now checks out github.sha from the base repository instead of ephemeral PR/merge-queue head refs, so cleanup is less likely to fail before running when temporary refs disappear.

How to test your changes?

  • cd packages/e2e && pnpm tsc --noEmit
  • cd packages/e2e && pnpm eslint "setup/**/*.ts" "helpers/**/*.ts" "tests/**/*.ts" "*.ts"
  • node bin/run-knip-ci.js

Note: ESLint completed successfully with existing Nx project graph cache warnings for @nx/enforce-module-boundaries. The PR E2E cleanup job will exercise the workflow path in CI.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is not user-facing; no changeset is needed.

Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
@alfonso-noriega alfonso-noriega requested a review from a team as a code owner July 1, 2026 14:22
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants