Skip to content

[Security] Harden client ID generation#7971

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-client-id-16556810634221208946
Closed

[Security] Harden client ID generation#7971
gonzaloriestra wants to merge 1 commit into
mainfrom
security-harden-client-id-16556810634221208946

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Hardens the client ID generation by using a cryptographically secure random number generator when available.

WHAT is this pull request doing?

Replaces the insecure Math.random() based client ID generation in ExtensionServerClient with globalThis.crypto.randomUUID() when supported by the environment, maintaining a fallback for compatibility.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 16556810634221208946 started by @gonzaloriestra

@gonzaloriestra
[Security] Harden client ID generation
c875cca 
Hardens client ID generation in ExtensionServerClient by using
globalThis.crypto.randomUUID() when available, falling back to
Math.random() for compatibility. Added unit tests to verify both
the secure path and the fallback.
@google-labs-jules

google-labs-jules Bot commented Jul 1, 2026

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. security

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gonzaloriestra