Skip to content

[Tests] Replace filesystem mock with real sparse file in bundle tests#7970

Closed
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mock-bundle-8432853696511868224
Closed

[Tests] Replace filesystem mock with real sparse file in bundle tests#7970
gonzaloriestra wants to merge 1 commit into
mainfrom
tests-remove-fs-mock-bundle-8432853696511868224

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The current tests for app bundling mock the filesystem to simulate large file sizes. This is an anti-pattern that can lead to fragile tests and hides the actual behavior of the filesystem utilities. Using real temporary directories and sparse files provides more robust verification of bundle size limits.

WHAT is this pull request doing?

  • Removes the module-level mock for @shopify/cli-kit/node/fs in packages/app/src/cli/services/bundle.test.ts.
  • Updates the large bundle upload test to use truncate from node:fs/promises to create a real 101 MB sparse file.
  • Ensures the test exercises the real fileSize utility from @shopify/cli-kit/node/fs.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 8432853696511868224 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant