Skip to content

Re-enable extension generation E2E#7964

Open
alfonso-noriega wants to merge 1 commit into
mainfrom
06-30-remove_skipped_extension_e2e
Open

Re-enable extension generation E2E#7964
alfonso-noriega wants to merge 1 commit into
mainfrom
06-30-remove_skipped_extension_e2e

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The app scaffold E2E suite had a skipped generate extensions and build test. The skip was tied to an old product_subscription_ui template path that is no longer present in the current extension template list and previously drove the test into Business Platform Organizations gating/auth behavior.

WHAT is this pull request doing?

Re-enables the E2E and updates the subscription-related generated extension to use the current subscription_link_extension template. The test still generates a subscription-related extension plus a theme app extension, then builds the app.

How to test your changes?

  • cd packages/e2e && pnpm tsc --noEmit
  • cd packages/e2e && pnpm eslint "setup/**/*.ts" "helpers/**/*.ts" "tests/**/*.ts" "*.ts"
  • node bin/run-knip-ci.js

Note: ESLint completed successfully with existing Nx project graph cache warnings for @nx/enforce-module-boundaries. The PR E2E job will run the re-enabled network test with CI credentials.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is not user-facing; no changeset is needed.

@alfonso-noriega alfonso-noriega requested a review from a team as a code owner June 30, 2026 14:11
@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 30, 2026
@alfonso-noriega alfonso-noriega force-pushed the 06-30-remove_skipped_extension_e2e branch from a577bde to 4dee169 Compare July 1, 2026 08:32
@alfonso-noriega alfonso-noriega changed the title Remove skipped extension generation E2E Re-enable extension generation E2E Jul 1, 2026
Assisted-By: devx/56dcddb4-0bb1-4e96-b794-1bb2fda2cba1
@alfonso-noriega alfonso-noriega force-pushed the 06-30-remove_skipped_extension_e2e branch from 4dee169 to 986ca21 Compare July 1, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants