Error before app config link prompts in non-TTY#7687
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
eebbb8e to
733fe27
Compare
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/private/node/constants.d.ts@@ -7,6 +7,7 @@ export declare const environmentVariables: {
enableCliRedirect: string;
env: string;
firstPartyDev: string;
+ hostedApps: string;
noAnalytics: string;
optOutInstrumentation: string;
appAutomationToken: string;
packages/cli-kit/dist/public/common/version.d.ts@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.1.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.0.0";
\ No newline at end of file
packages/cli-kit/dist/public/node/context/local.d.ts@@ -42,6 +42,13 @@ export declare function isShopify(env?: NodeJS.ProcessEnv): Promise<boolean>;
* @returns True if the SHOPIFY_UNIT_TEST environment variable is truthy.
*/
export declare function isUnitTest(env?: NodeJS.ProcessEnv): boolean;
+/**
+ * Returns true if the CLI is running in hosted apps mode.
+ *
+ * @param env - The environment variables from the environment of the current process.
+ * @returns True if the HOSTED_APPS environment variable is truthy.
+ */
+export declare function isHostedAppsMode(env?: NodeJS.ProcessEnv): boolean;
/**
* Returns true if reporting analytics is enabled.
*
|
e4069c5 to
c5d2d3f
Compare
3487ec3 to
a8e4e4a
Compare
a8e4e4a to
b24beaf
Compare
c5d2d3f to
2b45cf7
Compare
b24beaf to
8df1e6c
Compare
3fcd3c1 to
e4ccca0
Compare
8df1e6c to
954ecef
Compare
|
/snapit |
1 similar comment
|
/snapit |
19d3710 to
fbfc2d3
Compare
e4ccca0 to
469f7c2
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260616085935Caution After installing, validate the version by running |
fbfc2d3 to
c2d923e
Compare
469f7c2 to
1e5307e
Compare
|
/snapit |
1e5307e to
5a86eaf
Compare
c2d923e to
0fa5c90
Compare
|
/snapit |
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260616121718Caution After installing, validate the version by running |
0fa5c90 to
533857d
Compare
5a86eaf to
348790c
Compare
348790c to
0b212e4
Compare
533857d to
919b538
Compare

WHY are these changes introduced?
Related to https://github.com/shop/issues-develop/issues/22869
app config linkcan still reach prompt-only paths when a caller has not provided enough information to choose the remote app or local config file name. In non-interactive environments, that should fail with actionable guidance instead of attempting to render prompts.This is especially important for commands that call linking indirectly: they should surface that the project needs to be linked first with explicit flags, rather than hanging or failing inside prompt rendering.
WHAT is this pull request doing?
app config linkprompts for remote app selection.app config linkprompts for a new config file name.shopify app config linkwith the missing required flags, such as--client-idor--file-name.How to test your changes?
pnpm vitest run packages/app/src/cli/services/app/config/link.test.tspnpm vitest run packages/app/src/cli/services/app/config/link.test.ts packages/app/src/cli/commands/app/config/link.test.ts packages/app/src/cli/commands/app/config/validate.test.tsChecklist
pnpm changeset add