Skip to content

Error before app config link prompts in non-TTY#7687

Draft
gonzaloriestra wants to merge 1 commit into
cli-interactivity/theme-dev-reconciliationfrom
cli-interactivity/non-tty-link-error
Draft

Error before app config link prompts in non-TTY#7687
gonzaloriestra wants to merge 1 commit into
cli-interactivity/theme-dev-reconciliationfrom
cli-interactivity/non-tty-link-error

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Related to https://github.com/shop/issues-develop/issues/22869

app config link can still reach prompt-only paths when a caller has not provided enough information to choose the remote app or local config file name. In non-interactive environments, that should fail with actionable guidance instead of attempting to render prompts.

This is especially important for commands that call linking indirectly: they should surface that the project needs to be linked first with explicit flags, rather than hanging or failing inside prompt rendering.

WHAT is this pull request doing?

  • Adds a shared non-TTY guard before app config link prompts for remote app selection.
  • Adds the same guard before app config link prompts for a new config file name.
  • Suggests rerunning shopify app config link with the missing required flags, such as --client-id or --file-name.
  • Covers both non-TTY failure paths in the link service tests.

How to test your changes?

  • pnpm vitest run packages/app/src/cli/services/app/config/link.test.ts
  • pnpm vitest run packages/app/src/cli/services/app/config/link.test.ts packages/app/src/cli/commands/app/config/link.test.ts packages/app/src/cli/commands/app/config/validate.test.ts

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

gonzaloriestra commented Jun 1, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 1, 2026
@gonzaloriestra gonzaloriestra changed the base branch from cli-interactivity/app-config-validate to graphite-base/7687 June 1, 2026 12:39
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from eebbb8e to 733fe27 Compare June 1, 2026 12:39
@gonzaloriestra gonzaloriestra changed the base branch from graphite-base/7687 to cli-interactivity/theme-dev-reconciliation June 1, 2026 12:39
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -7,6 +7,7 @@ export declare const environmentVariables: {
     enableCliRedirect: string;
     env: string;
     firstPartyDev: string;
+    hostedApps: string;
     noAnalytics: string;
     optOutInstrumentation: string;
     appAutomationToken: string;
packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "4.1.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "4.0.0";
\ No newline at end of file
packages/cli-kit/dist/public/node/context/local.d.ts
@@ -42,6 +42,13 @@ export declare function isShopify(env?: NodeJS.ProcessEnv): Promise<boolean>;
  * @returns True if the SHOPIFY_UNIT_TEST environment variable is truthy.
  */
 export declare function isUnitTest(env?: NodeJS.ProcessEnv): boolean;
+/**
+ * Returns true if the CLI is running in hosted apps mode.
+ *
+ * @param env - The environment variables from the environment of the current process.
+ * @returns True if the HOSTED_APPS environment variable is truthy.
+ */
+export declare function isHostedAppsMode(env?: NodeJS.ProcessEnv): boolean;
 /**
  * Returns true if reporting analytics is enabled.
  *

@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch from e4069c5 to c5d2d3f Compare June 1, 2026 12:45
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch 2 times, most recently from 3487ec3 to a8e4e4a Compare June 1, 2026 13:43
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from a8e4e4a to b24beaf Compare June 15, 2026 10:53
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch from c5d2d3f to 2b45cf7 Compare June 15, 2026 10:53
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from b24beaf to 8df1e6c Compare June 15, 2026 11:40
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch 2 times, most recently from 3fcd3c1 to e4ccca0 Compare June 15, 2026 11:46
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from 8df1e6c to 954ecef Compare June 15, 2026 11:46

Copy link
Copy Markdown
Contributor Author

/snapit

1 similar comment

Copy link
Copy Markdown
Contributor Author

/snapit

@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from 19d3710 to fbfc2d3 Compare June 16, 2026 08:58
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch from e4ccca0 to 469f7c2 Compare June 16, 2026 08:58

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260616085935

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from fbfc2d3 to c2d923e Compare June 16, 2026 11:26
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch from 469f7c2 to 1e5307e Compare June 16, 2026 11:26

Copy link
Copy Markdown
Contributor Author

/snapit

@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch from 1e5307e to 5a86eaf Compare June 16, 2026 12:03
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from c2d923e to 0fa5c90 Compare June 16, 2026 12:03

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260616121718

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from 0fa5c90 to 533857d Compare July 1, 2026 14:10
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch from 5a86eaf to 348790c Compare July 1, 2026 14:10
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/theme-dev-reconciliation branch from 348790c to 0b212e4 Compare July 1, 2026 14:18
@gonzaloriestra gonzaloriestra force-pushed the cli-interactivity/non-tty-link-error branch from 533857d to 919b538 Compare July 1, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant