[AC]: add verbose logging #397
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kieran-osgood-shopify
force-pushed
the
kieran-osgood/feat/add-verbose-logging
branch
from
f3c2e54 to
7512ef7
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/feat/add-verbose-logging
branch
5 times, most recently
from
1b33b56 to
91dc780
Compare
| case .ready: | ||
| // No-op: error handler not called for success result | ||
| ShopifyAcceleratedCheckouts.logger.error("ErrorHandler: map: received unexpected result type from Cart API on prepare") | ||
| ShopifyAcceleratedCheckouts.logger |
There was a problem hiding this comment.
These methods are static so still using the global namespaced logger
kieran-osgood-shopify
force-pushed
the
kieran-osgood/feat/add-verbose-logging
branch
from
91dc780 to
fdf4cae
Compare
| identifier = .cart(cartID: cartID).parse() | ||
| if case let .invariant(reason) = identifier { | ||
| ShopifyAcceleratedCheckouts.logger.error(reason) | ||
| ShopifyAcceleratedCheckouts.logger.logError( |
There was a problem hiding this comment.
can't conform the Structs to Loggable so also using global here
kieran-osgood-shopify
force-pushed
the
kieran-osgood/feat/add-verbose-logging
branch
from
fdf4cae to
1f8ac8a
Compare
kieran-osgood-shopify
changed the title
kieran-osgood-shopify
force-pushed
the
kieran-osgood/feat/add-verbose-logging
branch
from
da00ce7 to
dd6f675
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Before you merge
Important
Releasing a new version of the kit?
podspecfile.Releasing a new major version?
Tip
See the Contributing documentation for instructions on how to publish a new version of the library.