fix(react-native): adapt Android bridge to CheckoutListener rename#155
Merged
kieran-osgood-shopify merged 1 commit intoMay 19, 2026
Conversation
PR #132 renamed DefaultCheckoutEventProcessor -> DefaultCheckoutListener and dropped onCheckoutCompleted from the listener. RN bridge wasn't updated alongside, breaking RN CI on main. Renames CustomCheckoutEventProcessor -> CustomCheckoutListener, swaps the parent class, drops the now-invalid onCheckoutCompleted override and its sample-test counterpart. iOS BridgeDelegate wiring deferred to a follow-up. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
React Native — Coverage Report
|
11 tasks
kiftio
approved these changes
May 19, 2026
Contributor
Author
Merge activity
|
kieran-osgood-shopify
deleted the
kieran-osgood/05-19-fixrnandroidbridgechecklistenerrename
branch
toneymathews
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
react native android CI was failing after #132 merged because it didn't run CI for react-native
This PR renames the android portion to match the new naming of the event processor
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
versionNameinplatforms/android/lib/build.gradleplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.