Skip to content

feat(protocol): add typescript interfaces#114

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/05-14-featprotocoladdtypescriptinterfaces
May 14, 2026
Merged

feat(protocol): add typescript interfaces#114
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/05-14-featprotocoladdtypescriptinterfaces

Conversation

@kieran-osgood-shopify
Copy link
Copy Markdown
Contributor

@kieran-osgood-shopify kieran-osgood-shopify commented May 14, 2026 •
edited
Loading

What changes are you making?

Generating the Typescript interfaces needed for UCP in react-native

How to test

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)
Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@kieran-osgood-shopify Graphite App
Copy link
Copy Markdown
Contributor Author

kieran-osgood-shopify commented May 14, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced May 14, 2026
Merged
Closed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 98%
 98.53% (202/205) 94.91% (112/118) 100% (61/61)

@kieran-osgood-shopify kieran-osgood-shopify added the #gsd:50662 Rebase Checkout Kit on UCP label May 14, 2026
@kieran-osgood-shopify kieran-osgood-shopify marked this pull request as ready for review May 14, 2026 16:33
@kieran-osgood-shopify kieran-osgood-shopify requested a review from a team as a code owner May 14, 2026 16:33
markmur
markmur approved these changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@markmur markmur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kieran-osgood-shopify kieran-osgood-shopify merged commit cacf47e into main May 14, 2026
16 checks passed
@kieran-osgood-shopify kieran-osgood-shopify deleted the kieran-osgood/05-14-featprotocoladdtypescriptinterfaces branch May 14, 2026 18:26
This was referenced May 14, 2026
Merged
Closed
This was referenced May 15, 2026
Merged
Merged
This was referenced May 15, 2026
Closed
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmur markmur markmur approved these changes

@kiftio kiftio kiftio approved these changes

Assignees

No one assigned

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kieran-osgood-shopify @markmur @kiftio