Skip to content

Conversation

@Ashlesha-MSFT
Copy link
Contributor

@Ashlesha-MSFT Ashlesha-MSFT commented Dec 29, 2025

Category

  • [x ] Content fix

What's in this Pull Request?

  • Migration from gulp to heft
  • Replace office-ui-fabric-react imports with @fluentui/react
  • Update import paths from /lib/components/* to /lib/*
  • Add TypeScript strict mode fixes (optional types with | undefined)
  • Add null checks for optional properties
  • Update build commands from gulp to heft
  • Add type annotations for TypeScript compatibility
  • Fix property pane control key assignment"

@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

@Ashlesha-MSFT Ashlesha-MSFT changed the title Update custom property pane docs Update Document for SPFx 1.22 (gulp to heft) Dec 29, 2025
@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Dec 30, 2025
@andrewconnell andrewconnell self-assigned this Dec 30, 2025
@andrewconnell andrewconnell self-requested a review December 30, 2025 12:43
@andrewconnell
Copy link
Collaborator

references #10545

@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these! I left some comments that need to be addressed. When you resolve each one, please mark it as resolved, selecting the button on each one to indicate it was addressed (making it easier to review).

## Preview the web part

You can preview and test your client-side web part in the SharePoint hosted workbench without deploying your solution to SharePoint. This is done by starting a local web server the hosted workbench can load files from using the gulp task **serve**.
You can preview and test your client-side web part in the SharePoint hosted workbench without deploying your solution to SharePoint. This is done by starting a local web server the hosted workbench can load files by using the **Heft start** command.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heft should be lowercase when running on the command line.

```

SharePoint client-side development tools use [gulp](http://gulpjs.com/) as the task runner to handle build process tasks such as:
SharePoint client-side development tools use [heft](https://heft.rushstack.io/) as the task runner to handle build process tasks such as:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heft is a proper name and should be uppercase when used in prose copy.

- Bundle and minify JavaScript and CSS files.

VS Code provides built-in support for gulp and other task runners. Select <kbd>CTRL</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on Windows or <kbd>CMD</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on macOS to debug and preview your web part.
VS Code provides built-in support for heft and other task runners. Select <kbd>CTRL</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on Windows or <kbd>CMD</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on macOS to debug and preview your web part.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heft is a proper name and should be uppercase when used in prose copy.


> [!NOTE]
> Keep the console window and Visual Studio Code side-by-side to see gulp automatically compile as you save changes in Visual Studio Code.
> Keep the console window and Visual Studio Code side-by-side to see heft automatically compile as you save changes in Visual Studio Code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heft is a proper name and should be uppercase when used in prose copy.


1. Save the file.
1. Switch to the console window that is running **gulp serve** and check if there are any errors. If there are errors, gulp reports them in the console, and you need to fix them before proceeding.
1. Switch to the console window that is running **heft start** and check if there are any errors. If there are errors, heft reports them in the console, and you need to fix them before proceeding.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heft is a proper name and should be uppercase when used in prose copy (the 2nd instance in this line).

![Render lists data from localhost](../../../images/sp-lists-render-online-workbench.png)
1. Now you can stop the server from running. Switch to the console and stop **gulp serve**. Select <kbd>CTRL</kbd>+<kbd>C</kbd> to stop the gulp task.
1. Now you can stop the server from running. Switch to the console and stop **heft start**. Select <kbd>CTRL</kbd>+<kbd>C</kbd> to stop the heft task.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about heft casing as previously posted

### Package contents

The package uses SharePoint Feature to package your web part. By default, the gulp task creates a feature for your web part.
The package uses SharePoint Feature to package your web part. By default, the heft task creates a feature for your web part.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about heft casing as previously posted


1. *Before* adding the web part to a SharePoint server-side page, run the local server.
1. In the console window that has the **helloworld-webpart** project directory, run the gulp task to start serving from localhost:
1. In the console window that has the **helloworld-webpart** project directory, run the heft task to start serving from localhost:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about heft casing

@andrewconnell
Copy link
Collaborator

@Ashlesha-MSFT Thanks for these! Since opening this PR, we've implemented a master tracker issue for all updates that need to be addressed

#10545

In the future, can you follow the instructions in that issue, as multiple people will be working off this list & it will help to ensure we don't have more than one person working on the same thing.

Thanks!

@andrewconnell andrewconnell added Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged and removed pr:in-review Actively reviewing pull request labels Dec 30, 2025
@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@Ashlesha-MSFT
Copy link
Contributor Author

@andrewconnell,
I’ve addressed all the review comments as directed and updated the documentation accordingly — including fixing the Heft/heft casing (uppercase in prose, lowercase for CLI commands). All comments have been resolved.

Thank you for the detailed review and guidance 👍

Noted about the master tracker issue #10545 — I’ll make sure to follow that process for any future updates to avoid overlap.

Appreciate the review and feedback!

@learn-build-service-prod
Copy link
Contributor

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@andrewconnell
Copy link
Collaborator

@Ashlesha-MSFT said:

All comments have been resolved.

When you do this, can you literally mark them as resolved? That's what I meant when I had this in my comment:

When you resolve each one, please mark it as resolved, selecting the button on each one to indicate it was addressed (making it easier to review).

You can do this by clicking the Resolve Conversation button... it helps quickly verify the necessary changes have been addressed (like in the above comment):

image

Thanks!

@andrewconnell andrewconnell added pr:in-review Actively reviewing pull request pr:ready-to-merge Ready to merge PR and removed Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged pr:in-review Actively reviewing pull request labels Dec 31, 2025
@andrewconnell andrewconnell merged commit f341d30 into SharePoint:main Dec 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-to-merge Ready to merge PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants