-
Notifications
You must be signed in to change notification settings - Fork 1k
Update Document for SPFx 1.22 (gulp to heft) #10544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Document for SPFx 1.22 (gulp to heft) #10544
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit c2c59be: ✅ Validation status: passed
For more details, please refer to the build report. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 03c7ef6: ✅ Validation status: passedFor more details, please refer to the build report. |
|
references #10545 |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 1ee6bc3: ✅ Validation status: passedFor more details, please refer to the build report. |
andrewconnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these! I left some comments that need to be addressed. When you resolve each one, please mark it as resolved, selecting the button on each one to indicate it was addressed (making it easier to review).
| ## Preview the web part | ||
|
|
||
| You can preview and test your client-side web part in the SharePoint hosted workbench without deploying your solution to SharePoint. This is done by starting a local web server the hosted workbench can load files from using the gulp task **serve**. | ||
| You can preview and test your client-side web part in the SharePoint hosted workbench without deploying your solution to SharePoint. This is done by starting a local web server the hosted workbench can load files by using the **Heft start** command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heft should be lowercase when running on the command line.
| ``` | ||
|
|
||
| SharePoint client-side development tools use [gulp](http://gulpjs.com/) as the task runner to handle build process tasks such as: | ||
| SharePoint client-side development tools use [heft](https://heft.rushstack.io/) as the task runner to handle build process tasks such as: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heft is a proper name and should be uppercase when used in prose copy.
| - Bundle and minify JavaScript and CSS files. | ||
|
|
||
| VS Code provides built-in support for gulp and other task runners. Select <kbd>CTRL</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on Windows or <kbd>CMD</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on macOS to debug and preview your web part. | ||
| VS Code provides built-in support for heft and other task runners. Select <kbd>CTRL</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on Windows or <kbd>CMD</kbd>+<kbd>SHIFT</kbd>+<kbd>B</kbd> on macOS to debug and preview your web part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heft is a proper name and should be uppercase when used in prose copy.
|
|
||
| > [!NOTE] | ||
| > Keep the console window and Visual Studio Code side-by-side to see gulp automatically compile as you save changes in Visual Studio Code. | ||
| > Keep the console window and Visual Studio Code side-by-side to see heft automatically compile as you save changes in Visual Studio Code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heft is a proper name and should be uppercase when used in prose copy.
|
|
||
| 1. Save the file. | ||
| 1. Switch to the console window that is running **gulp serve** and check if there are any errors. If there are errors, gulp reports them in the console, and you need to fix them before proceeding. | ||
| 1. Switch to the console window that is running **heft start** and check if there are any errors. If there are errors, heft reports them in the console, and you need to fix them before proceeding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heft is a proper name and should be uppercase when used in prose copy (the 2nd instance in this line).
|  | ||
| 1. Now you can stop the server from running. Switch to the console and stop **gulp serve**. Select <kbd>CTRL</kbd>+<kbd>C</kbd> to stop the gulp task. | ||
| 1. Now you can stop the server from running. Switch to the console and stop **heft start**. Select <kbd>CTRL</kbd>+<kbd>C</kbd> to stop the heft task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment about heft casing as previously posted
| ### Package contents | ||
|
|
||
| The package uses SharePoint Feature to package your web part. By default, the gulp task creates a feature for your web part. | ||
| The package uses SharePoint Feature to package your web part. By default, the heft task creates a feature for your web part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment about heft casing as previously posted
|
|
||
| 1. *Before* adding the web part to a SharePoint server-side page, run the local server. | ||
| 1. In the console window that has the **helloworld-webpart** project directory, run the gulp task to start serving from localhost: | ||
| 1. In the console window that has the **helloworld-webpart** project directory, run the heft task to start serving from localhost: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment about heft casing
|
@Ashlesha-MSFT Thanks for these! Since opening this PR, we've implemented a master tracker issue for all updates that need to be addressed In the future, can you follow the instructions in that issue, as multiple people will be working off this list & it will help to ensure we don't have more than one person working on the same thing. Thanks! |
…nto update-custom-property-pane-docs
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 472d132: ✅ Validation status: passedFor more details, please refer to the build report. |
|
@andrewconnell, Thank you for the detailed review and guidance 👍 Noted about the master tracker issue #10545 — I’ll make sure to follow that process for any future updates to avoid overlap. Appreciate the review and feedback! |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 1566240: ✅ Validation status: passedFor more details, please refer to the build report. |
|
@Ashlesha-MSFT said:
When you do this, can you literally mark them as resolved? That's what I meant when I had this in my comment:
You can do this by clicking the Resolve Conversation button... it helps quickly verify the necessary changes have been addressed (like in the above comment):
Thanks! |

Category
What's in this Pull Request?