Skip to content
This repository was archived by the owner on Mar 31, 2025. It is now read-only.

windows dark mode/color support + dpi fix + cpp cleanup #16409

Closed
wants to merge 1 commit into from

Conversation

cyn0x8
Copy link
Contributor

@cyn0x8 cyn0x8 commented Mar 5, 2025

semi mirror pr of FunkinCrew/Funkin#4267

  • moves window functions into backend.Native
  • better dpi awareness (and draws black for a frame so theres no ugly white border)
  • added dark theme support toggle function
  • added window bar/text/border color functions
  • also prunes some of the existing cpp code that is unused
2025-03-08.21-34-43.mp4

@cyn0x8 cyn0x8 marked this pull request as draft March 5, 2025 19:04
@cyn0x8 cyn0x8 marked this pull request as ready for review March 6, 2025 10:28
@cyn0x8 cyn0x8 changed the title windows dark theme support + cpp cleanup windows dark mode/color support + dpi fix + cpp cleanup Mar 9, 2025
@FearmongerWade
Copy link
Contributor

thumbs up

@cyn0x8 cyn0x8 marked this pull request as draft March 10, 2025 01:05
@cyn0x8 cyn0x8 marked this pull request as ready for review March 10, 2025 06:21
@ShadowMario
Copy link
Owner

ShadowMario commented Mar 20, 2025

This PR has some problems running on Windows 10 and previous.
If possible, don't make it turn dark mode on by default.

cmd_9g8B5rlHNG.mp4

@ShadowMario
Copy link
Owner

This PR has some problems running on Windows 10 and previous. If possible, don't make it turn dark mode on by default.

After further thinking, I might reject this PR because of the Dark mode, it's kinda buggy

@cyn0x8
Copy link
Contributor Author

cyn0x8 commented Mar 20, 2025

i can emulate win10 to figure out what might be going on

@cyn0x8 cyn0x8 marked this pull request as draft March 20, 2025 17:58
@DMMaster636
Copy link
Contributor

DMMaster636 commented Mar 21, 2025

This PR has some problems running on Windows 10 and previous. If possible, don't make it turn dark mode on by default.

actually, this only happens when doing it in the Main.hx for some reason
in a mod I work on, I made an InitState.hx that handles initializing stuff and having the code there actually fixed the problem
unsure why, but it be like that .>.

@DMMaster636
Copy link
Contributor

tho, an easy way to fix this is to just redraw the header, so for example enabling and disabling borderless
flixel.FlxG.stage.window.borderless = true; flixel.FlxG.stage.window.borderless = false;
it may not be the most optimal solution (because there is a little flash/jitter), but it works

@ShadowMario
Copy link
Owner

Windows 10 has no native support for changing window colors and stuff, so I'm going to have to close this, the PR will be partially implemented and credited though

ShadowMario added a commit that referenced this pull request Mar 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants