fix(OrangePi NEO): Improve Touchpad Support #435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pastaq
commented
Sep 10, 2025
pastaq
commented
- Apply similar changes as fix(Legion Go/2): Improve Go/Go2 Support #432 to improve the OrangePi NEO in the same way.
- Apply similar changes as #432 to improve the OrangePi NEO in the same way.
ShadowApex
reviewed
Sep 16, 2025
| OutputCapability::LED(LED::Color), | ||
| ]; | ||
| /// List of all output capabilities that the OrangePi NEO supports | ||
| pub const OUTPUT_CAPABILITIES: &[OutputCapability] = &[OutputCapability::ForceFeedback]; |
Contributor
There was a problem hiding this comment.
Does the OrangePi Neo not support LEDs?
Contributor
Author
There was a problem hiding this comment.
It has RGB that is only controlled through button combo's on the device. OrangePi did not want to spend the money for an API for the MCU.
Comment on lines
+251
to
+255
| // The touchpad doesn't have a force sensor. The deck target wont produce a "click" | ||
| // event in desktop or lizard mode without a force value. Simulate a 1/4 press to work | ||
| // around this. | ||
| let event = Event::Trigger(TriggerEvent::PadForce(TriggerInput { value: 0 })); | ||
| events.push(event); |
Contributor
There was a problem hiding this comment.
Instead of emulating the touch force in the source device, can we instead handle this in the target device(s)?
Contributor
Author
There was a problem hiding this comment.
I'd rather not manage source device edge cases in target devices.
Co-authored-by: William Edwards <[email protected]>
Contributor
|
@pastaq I didn't saw any regressions when I tested it on the Neo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.