Skip to content

Gs.info check #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Gs.info check #140

wants to merge 8 commits into from

Conversation

Rampriya-S
Copy link
Contributor

This pull request contains Script only check to find gs.log() in Client scripts, Business rules and Script includes.

…st Framework to ensure functionality after updates and deployments.
…n service portal. Instead we should use AngularJS equivalent capabilities to achieve the same.
…n service portal. Instead we should use AngularJS equivalent capabilities to achieve the same.
…It is easier to read, it gives the compiler a chance to optimize your code, and it's mostly faster too.
…sent in Client scripts, Business rules and Script incluedes
…Test Framework to ensure functionality after updates and deployments.
…Test Framework to ensure functionality after updates and deployments.
…nt scripts, Business rules and Script includes.
@niamccash
Copy link
Contributor

Thanks for your submission. It appears that this pull request still contains more files than described in the title. Please review and update the pull request to either remove the extra/unintended files or to update the description to be more comprehensive. Ensure your contributions are meaningful and adhere to the project’s standards. You can create a new branch on your forked repository to avoid accidental inclusions of new commits in the future. You also didn't add to the readme.md file as I requested in my last feedback. Closing this. Once you make additional changes, feel free to re-open this Pull Request or create a new one.

@niamccash niamccash closed this Oct 15, 2024
@Rampriya-S
Copy link
Contributor Author

@niamccash I have created new branch, but still it is pulling multiple files. I want to submit https://github.com/ServiceNowDevProgram/example-instancescan-checks/pull/140/files#diff-0e7ff7f7aa46c0b21b6412606b8de117c2bfff63aec0a7fb684e88ea34ad3ec2

file alone. Could you please delete the rest for me>

@Rampriya-S
Copy link
Contributor Author

@niamccash Can you please help me how to remove the unnecessary files?

@niamccash
Copy link
Contributor

Here's what I'd recommend...
In your master branch, sync your fork to get it up to date with the latest version that's already approved in the ServiceNow Dev program account:
image

Update your instance with the master branch and stash any work in progress you might have.
Then create a NEW branch, and add the instance check you want to submit.

@Rampriya-S Rampriya-S deleted the gs.info_check branch October 15, 2024 17:35
@Rampriya-S
Copy link
Contributor Author

@niamccash Thanks for your advice. It's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants