Adds a new instance check to notify about the possible risk associated with the usage of setWorkflow(false) method in business rule

[aswamy93]

As setWorkflow(false) method will stop the execution of business rules on that particular GlideRecord object, this will result in unexpected behaviour where the execution of business rules skipped. Maintain caution while using this method and perform regression testing to avoid possible risk. It can have noticeable impact on Audit, Journal fields, notifications, SLA engine, workflow, flow engine etc.,

[niamccash]

hi @aswamy93 Thank you for your contribution. Looks good. Could you please update the readme file to include a description of your newly added check so that other people contributing know that it's there and don't duplicate?

[aswamy93]

hi @aswamy93 Thank you for your contribution. Looks good. Could you please update the readme file to include a description of your newly added check so that other people contributing know that it's there and don't duplicate?

Hi @niamccash
Many thanks for the review,. I have update the readme file and created another pull request: #120. Please check it when you get a chance

[niamccash]

hi @aswamy93
Can you please add the readme changes to this same PR? I think you should be able to go into your new_addition branch and update the readme file in that same branch to update this PR.

[aswamy93]

hi @aswamy93 Can you please add the readme changes to this same PR? I think you should be able to go into your new_addition branch and update the readme file in that same branch to update this PR.

Hi @niamccash , There is no option to merge pull requests. Though I switched to new_addition brand updated readme but looks like I created another pull request. Sorry for the multiple pull requests for the same one.

[niamccash]

How are you editing the readme file - in the browser or on your local computer? Can you try to go to https://github.com/aswamy93/example-instancescan-checks/tree/new_addition and edit the readme file there and commit?

It looks like you weren't working in the new_addition branch for your new PR. It was a new branch altogether.

[aswamy93]

How are you editing the readme file - in the browser or on your local computer? Can you try to go to https://github.com/aswamy93/example-instancescan-checks/tree/new_addition and edit the readme file there and commit?

It looks like you weren't working in the new_addition branch for your new PR. It was a new branch altogether.

Hi @niamccash , Sorry, my bad. I followed your steps and committed the changes without creating pull requests. Now, I can see that the readme file is captured in this pull requests. Thank you so much for your help

[SapphicFire]

Addressed checksum conflict - will leave ownership of PR review and merge with Nia :)

[niamccash]

Thanks for the help @SapphicFire!