Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick most of "Qt: Fix -Werror=deprecated-declarations when using Qt > 6.7" #25687

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

nico
Copy link
Contributor

@nico nico commented Feb 6, 2025

(cherry picked from commit 07400b515c3d8d03bf3d6e35c26ec8a3d7317560; amended to omit change to code added in LadybirdBrowser/ladybird#1497 since we don't have that yet)


LadybirdBrowser/ladybird#1807

(cherry picked from commit 07400b515c3d8d03bf3d6e35c26ec8a3d7317560;
amended to omit change to code added in LadybirdBrowser/ladybird#1497
since we don't have that yet)
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Feb 6, 2025
@nico
Copy link
Contributor Author

nico commented Feb 6, 2025

Doing this now because Homebrew/homebrew-core#202172 updated Qt on Mac to 6.8, and things no longer build without it due to deprecation warnings. A mostly complete cherry pick seems nicer than the alternatives.

@nico nico merged commit 7d1926c into SerenityOS:master Feb 6, 2025
12 checks passed
@nico nico deleted the qt68 branch February 6, 2025 14:04
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants