LibGfx+LibGUI: Small grabbag of jpeg2000-related tweaks #25671
Conversation
This should have been part of f2e381a in SerenityOS#24016. The Bitmap.h change has the effect that FileManager now shows a preview of buggie-gray.jpf when opening /usr/Tests/LibGfx/test-inputs/jpeg2000.
...for compression_type and enumerated_color_space values. (Since these are open fields, the field type can't be an enum.)
github-actions
bot
added
the
👀 pr-needs-review
| @@ -25,6 +25,43 @@ struct JPEG2000ImageHeaderBox final : public Box { | |||
| u8 compression_type { 0 }; | |||
| u8 is_colorspace_unknown { 0 }; | |||
| u8 contains_intellectual_property_rights { 0 }; | |||
|
|
|||
There was a problem hiding this comment.
I don't understand why you are adding these enums if we can't use them 🤔
There was a problem hiding this comment.
Also don't enums allow not listed values?
There was a problem hiding this comment.
We can use them to compare against, see 4th commit. But we "can't" use them as the type of the field. (Since it's just an enum, not an enum class, comparing ints against them works without casts.)
enums do allow not listed values, especially with an explicit underlying type, but that's something we don't usually use. I think clang doesn't warn if you switch over an enum and handle all listed values, and for gcc the kinda automatic fix for the diag is to add a VERIFY_NOT_REACHED() after the switch, which here would be wrong.
github-actions
bot
removed
the
👀 pr-needs-review
|
Thanks for taking a look 🙂 |
LibGfx+LibGUI: Add .jpf to known image extensions
This should have been part of f2e381a in #24016.
The Bitmap.h change has the effect that FileManager now shows a
preview of buggie-gray.jpf when opening
/usr/Tests/LibGfx/test-inputs/jpeg2000.
LibGfx/JPEG2000: Dump ISOBMFF boxes in JPEG2000_DEBUG builds
LibGfx/ISOBMFF/JPEG2000: Add a few known values
...for compression_type and enumerated_color_space values.
(Since these are open fields, the field type can't be an enum.)
LibGfx/JPEG2000: Reject images that do not use JPEG2000 compression