Base: Some cleanups by moving /res folders to /usr/share and removing some useless config files #25606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
bplaat
changed the title
|
I'm not entirely sure about the motivation here, but leaving that bit aside, I personally like having config files that specify the default behaviour instead of having them hidden in the code. |
|
The default values must are already be in the code, so the files are not needed. In the end we need to move all the files out of the anon home folder because it won't work when creating other users. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
timschumi
requested changes
Feb 1, 2025
| @@ -74,7 +74,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments) | |||
| { | |||
| TRY(Core::System::pledge("stdio rpath")); | |||
|
|
|||
| StringView path = "/res/fortunes.json"sv; | |||
There was a problem hiding this comment.
Doing this will also require an update to the Discord bot.
|
Ah good point, when I've time I'll look into it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits clean up the
/resand/home/anon/.configfolders a bit.All application specific non graphic files need to exist in
/usr/shareand not in/resso I moved them. Only/res/ladybirdremains but that folder is special in the build system and would require a larger refactor.Also where there some all default config files which could easily be removed, they are created on the fly when settings are changed.
Some files in
/home/anon/.configto be moved to a more global dir, for better multi user support but I'll look into that in the future.